Problem reported when there is no problem

rabol

This code fragment gives a 'problem' warning: Assigning "void" from a function get()

        foreach ($templateFieldsValues as $tfvKey => $values) {
            $keys = array_keys($values);
            foreach ($keys as $key) {
                if (Arr::get($this->tfValues, $key)) {
                    $templateFieldsValues[$tfvKey][$key] = Arr::get($this->tfValues, $key); //<<<< this line
                }
            }

        }

JakubMisek

rabol thank you for reporting the issue.

We usually report this, when there is a potential error in the code.

Is Arr::get() returning something? We might get this one wrong.

Thank you!

rabol

Yes It's returning the value - Arr:get() will never be a void as it will return the default value or null

JakubMisek

rabol May I ask about the get() function?

What does it look like? Does it have a doc comment with @return or is there just return something; ? We're probably getting this wrong.

rabol

    /**
     * Get an item from an array using "dot" notation.
     *
     * @param  \ArrayAccess|array  $array
     * @param  string|int|null  $key
     * @param  mixed  $default
     * @return mixed
     */

But two lines above, the method is ok

JakubMisek

rabol Thank you, we incorrectly treat it as it returns null only ... I'll take a look on that.

rabol

well, null is not void 😂

JakubMisek

rabol haha, right :-D so we messed something else up ... it thinks that get() returns void for some reason

JakubMisek

May I ask what you have in the tool-tip over Arr::get( ?

rabol

I have this:

JakubMisek

rabol Thank you. From the tooltip it looks alright ...

I'll keep looking for the error somewhere else.