Caching the hard drive for third-party libraries

ging-dev

i think caching some third party components (eg vendor) will speed up indexing after every vscode startup and significantly reduce RAM consumption

JakubMisek

ging-dev Thank you for the suggestion!

We have actually just implemented that (it took a few weeks/months to do it.)

Currently we're testing this feature in closed beta, preparing pre-release soon.

JakubMisek

We have released pre-release that caches composer packages. Please let us know how it works.

Details on the progress are in > VSCode > OUTPUT > PHP Language Server

ging-dev

JakubMisek thank you for hard work!, through a few tests, it seems the constant is not indexed, i get the message Undefined class constant ...

In https://github.com/doctrine/DoctrineBundle/blob/2.10.x/Repository/ServiceEntityRepository.php , there are two ways to declare an object using the if block, but the code generated by LSP has only 1 case:

class ServiceEntityRepository extends LazyServiceEntityRepository
{
}

JakubMisek

ging-dev thank you for the quick test - you're right, class constants are missing.

ging-dev

JakubMisek Is the Go to definition feature currently opening to a temporary file created by the LSP for testing purposes?

JakubMisek

ging-dev yes, currently the entire vendor is treated as an external library and goto opens the generated representation of it.

This will change before the full release.

ging-dev

JakubMisek also, where is the cache stored? I want to clean them up for testing purposes. There are a few test cases that don't work that I reproduced at https://github.com/ging-dev/devsense-lsp-reproduce

JakubMisek

ging-dev the cache will be configurable.

For now, it's in %localappdata%/DEVSENSE/packages-cache

JakubMisek

ging-dev Thank you for the test cases - I'll look into it

JakubMisek

ging-dev pre-release has been updated, thank you.

ging-dev

JakubMisek I found a new bug: https://github.com/ging-dev/devsense-lsp-reproduce/commit/749a22f3d9b74f854c41d856ab6f1c0ab3669da6

JakubMisek

ging-dev Thank you for all the great test cases. We have a bunch of fixes in caching the packages with template types, and working on this issue as well. Pre-Release will be within 1-2 days.

JakubMisek

ging-dev pre-release 1.37.13695 should deal with generics and type inheritance in cached /vendor/ folder.

In some cases, it prefers mixed over a doc comment in an inherited class for now, but we'll keep fine-tuning that.

ging-dev

JakubMisek
autocomplete on array shape seems to suggest some unnecessary stuff, it seems to have existed since the previous version

reproduce: https://github.com/ging-dev/devsense-lsp-reproduce/commit/f59ce0f212e097b5a92225a814b6586f29cd171b

JakubMisek

ging-dev Thank you;

It showed use aliases for some reason, I've disabled it in case of completing inside array indexer [].

@psalm-import-type has been added, we've supported only @phpstan-import-type before.

ging-dev

JakubMisek thank!, @psalm-import-type worked, but the vendor type alias doesn't seem to be cached yet.

ging-dev

JakubMisek

When I type ctrl+space at the constructor, I get quite a few hints of the classes included in the exclusion list. Looks like LSP still indexes and stores excluded classes?

JakubMisek

ging-dev thank you for testing so quickly.

There are type aliases in vendor(s)?? May I ask what package has type aliases?

EDIT: oh, maybe @psalm-type-alias used within the cached package might stop working - I see now. And @psalm-type is not exported so it can't be used outside the cached package, right.

JakubMisek

ging-dev classes excluded using "files.exclude" setting?

ging-dev

JakubMisek ah yes, my fault. Seems like hover of final class may not show