High resources

phptools

I think I found the issue, in my /vendor/my/package, I have another vendor folder because of some testing. Deleting the nested vendor folder solved the issue.

Avoiding nested vendor folders can be a nice feature to add to the language server. :)

JakubMisek

phptools good test case - I'll try that!

JakubMisek

phptools is it some publically available package, that contains another /vendor/ ?

phptools

JakubMisek

This will affect all projects/frameworks based on composer
Typically, folder structure will be /project/vendor where all composer packages reside in vendor
However, there are times when a composer package inside vendor might be developed along side the project
And we might run composer update to verify that the package being developed can be tested on a standalone basis, but this also creates /project/vendor/my/package/vendor
In my view, there is no need for the language server to scan the nested vendor folder
I'm quite certain that was the issue that cause the high resource consumption for me yesterday

Able to follow what I'm saying?

JakubMisek

phptools I see, it makes sense.

As a result, we wouldn't be providing code completion within the' vendor' folder though.

phptools

JakubMisek

Hmm the 1st vendor must be scanned, but not the 2nd. Correct?

JakubMisek

phptools I guess we have to scan all the .php files. The 2nd vendor might be needed in order to analyse the 1st vendor right?

phptools

JakubMisek

Composer is a flat single layer dependency manager, so all the required files are in the first vendor. As such, there is no need to scan the 2nd vendor.

But I would suggest this to be made as a generic configuration rather than 1 specific to composer, perhaps exclude scanning vendor/**/vendor?

JakubMisek

phptools I see. But the 2nd vendor contains declarations needed by a package in the 1st vendor right?

phptools

JakubMisek

2nd vendor contains declarations needed by a package in the 1st vendor right?

Yes, but because composer operates on only 1 level, those declarations are already found in the 1st vendor. As such there is no need to scan the 2nd vendor

Let's say the project is A, and it needs B. B needs C
When we run composer require B, this command will also add C into the project, thus 1st vendor will already know about C
There is no need to scan B's vendor to know about C

Makes sense?

phptools

In case you wonder why the 2nd vendor is exists, that is because the package B looks inside its child folders for the packages it needs, it will not look towards its parent(s)

JakubMisek

phptools I see! right, it doesn't make sense to scan the nested vendor folder then.

JakubMisek

phptools For that purpose, I thought the composer had an API providing the list of installed packages, their paths, and package dependencies.

JakubMisek

pre-release 1.37.13695 ignores the nested /vendor/, please let me know how it works for you)

JakubMisek

Version 1.38 avoids allocating and indexing /vendor/ folder if not necessary. There is a new caching mechanism and several improvements.

Please update and let us know how it works.

Thanks!

phptools

JakubMisek

My v1.39.13943 language server is taking very long to do its job again. Any idea?

phptools

it is taking over 5 minutes...

JakubMisek

phptools It should not be more than a few seconds.

Please try the pre-release 1.39.13983 which handles symlinks in /vendor/ folder - it seems like it's your case.

phptools

Not sure what I did, but it seems better now. Here's what happened:

It was slow, I did a reboot, still slow, so I sent the screenshot above

I did add this

    "files.exclude": {
    "inherit": true,
    "**/vendor/**/vendor/**": true // had no effect whether enabled or not
},
//excludes fies & folders for watcher service
"files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true,
    "**/env/**": true,
    "**/venv/**": true
},
"search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/env": true,
    "**/venv": true
},

phptools

JakubMisek

Go to Definition breaks when I add this, feels like a bug to me

    "files.exclude": {   
        "**/vendor/**/vendor/**": true
    },

Is there a way to make the extension stay on a certain version so that I can stay in a known state? Perhaps using a configuration setting?