Auto-completion, intellisense and debugging

MichaelW

Product: PHP Tools for Visual Studio
Version: 1.78.19108.2022
PHP Version 8.2

I tend to make regular use of named parameters for functions. Auto-completion often changes the parameter label I type into something inappropriate, e.g. "format:" become "$format", or "Format:" plus a corresponding irrelvant use statement for a spurious "Format" class. Another example is when typing an array index reference. Trying to type say "[0]" can become "[COLORSPACE_REC601LUMA]" as its the selected completion suggestion.
I widely use enumerations. The latest release has stopped showing the intelligence list of cases, which is unhelpful.
Peek definition or Go to Definition does not work for static functions. E.g. static_class::function_name does sees nothing happens when using Peek or Go
The debugger will not show static values, either in local/auto windows or when attempting to see the variable's value in the code.

Michael

JakubMisek

MichaelW Thank you for the details.

I've improved 1/ - when the label i.e. format: is fully typed, it gets priority over other members in the completion list and completes correctly. Also when completing items in array brackets, we won't be pre-selecting matches in the completion list so they won't get completed unless explicitly selected with cursor keys.

2/ it seems to work for me:

Do you have an example? Is the enum declared in your user's code or a /vendor composer package?

3/ might be fixed in the upcoming Preview version

4/ I'm afraid PHP treats static properties differently, so our debugger does not see them - BUT we'll investigate further.

JakubMisek

Please try the Pre-Release at https://www.devsense.com/en/download

MichaelW

I overlooked my Visual Studio 2022 version, which is 17.8.6.

The enums are declared in separate code files within my own application. The issue is endemic across multiple PHP projects using PHP Tools. I get no response after entering the double colon of any enum. Some sample code from my current (WordPress plugin) project is shown below:

namespace aCore\includes\enums;
enum e_on_input: string {
case hide = "hide";
case show = "show";
}
I invariably back my enums as there are times when its useful to set them using application values.

// Form fields
$this->fields->set( name: 'lookup_id' , width: '160', on_input: e_on_input::hide, value: $model->lookup_id );
$this->fields->set( name: 'parent_id' , width: '160', on_input: e_on_input::hide, value: cache::$parent_key->value );
$this->fields->set( name: 'group_key' , width: '160', label: 'Status Key' );
$this->fields->set( name: 'group_sequence', width: '60', label: 'Status Sequence' );
$this->fields->set( name: 'name' , width: '300' );
$this->fields->set( name: 'is_active', format: e_format::checkbox );

I tested an older project from about a year ago. I do not recall having any issues at the time, but it too exhibits the same issue now.

Michael

JakubMisek

MichaelW Thank you,

Does the navigation work for those enums? i.e. click on e_on_input and Go To Definition, or F12

Are they properly imported using use aCore\includes\enums\e_on_input;?

MichaelW

JakubMisek Manual navigation works. Clicking on the enum takes you to the enum class file. Hovering over the enum correctly identifies it as a BackedEnum and reports the correct namespace. The enum class file contains its namespace and the file loads successfully from it using a custom registered loader from its use statement.

I created a simple test project of one code class plus an enum class. This test project exhibits the same issue, so it would seem the resolution of the matter must lie somewhere in my PHP Tools configuration or installation.

JakubMisek

MichaelW May I ask for the simple test project? It would help me to create unit tests and fix them quickly.

Thank you!

MichaelW

JakubMisek

Below is the full test project in a single text file. I tried a zip file, but it was rejected.

test-project-as-text.txt

2kB

JakubMisek

MichaelW Thank you very much for the test case.

(For some reason, I can see the uploaded .zip as well)

I was playing around with the completion, and it seems it works in my case:

A known issue - if the code contains a syntax error, completion may be dumb at the moment.

Are there any specific steps I could try?

MichaelW

It seems implausible that even significant syntax errors would cause the issue I am seeing. I have just reloaded my test project (which has no syntax errors) and still have the issue when I attempt to get the popup.

Perhaps what I should try is a full re-install of PHP Tools. It looks to be more of an internal configuation issue than anything else. I am sure other users would have raised this issue had they been affected by it.

I will report back on the reinstallation.

MichaelW

The issue looks to be resolved. The 1.78.19178 release is now showing the enum popups.

Thank you for your support.

JakubMisek

MichaelW Thank you for the update.

This feature is supported from the very beginning of enums in PHP;

So as you said - it was more likely that PHP Tools were not installed correctly in Visual Studio.

JakubMisek

MichaelW Thank you for the update.

This feature is supported from the very beginning of enums in PHP;

So as you said - it was more likely that PHP Tools were not installed correctly in Visual Studio.