Native enum class hinting problem

AlexKratky

I guess something went bad and now I do not get any hint for possible values for that enum class as seen on screenshot - I have enum DisponentModifier where one value of that enum is 'Any', but on screenshot there is no possible value, only just some guessing on what I write most. When I write 'An', there is a yellow underline indicating incorrect value, but after typing whole name ('Any'), yellow underline goes away. I think this is problem only with new enum class, as with the classic class constant there is no problem.

JakubMisek

AlexKratky thank you for noticing, we'll take a look on that asap.

AlexKratky

Hinting for native enum worked in past and start being problem in like last 7-10 days.

JakubMisek

It seems like the editor does not recognize DisponentModifier at all (but there is no warning about it I guess). For me it's as expected:

Isn't there another (un)related warning with DisponentModifier ? Where is it defined?

weissersand

Afaik enum is case sensitive which seems to be ignored:

<?php
enum Size:int
{
    case small = 1;
    case SMALL = 2;
    case LARGE = 3;
}
echo Size::small->value;
echo Size::SMALL->value;
echo Size::large->value;
echo Size::medium->value;

PHP throws Fatal error: Uncaught Error: Undefined constant Size::large in ... :10.

VS Code:
There is no warning/problem "Undefined constant Size::large".
There is a warning/problem "Undefined class constant Size::medium".

JakubMisek

weissersand Thank you for the sample! We'll fix the case-sensitivity.

weissersand

Thank you. Maybe related:

<?php
declare(strict_types=1);

const c = ['foo' => true];
echo c['bar'];
echo c['FOO'];

$a = ['foo' => true];
echo $a['bar'];

echo $bar;

Single Problem (which disappears without declare(strict_types=1);) has unexpected message:

[{
	"resource": "....php",
	"owner": "_generated_diagnostic_collection_name_#7",
	"code": "PHP0406",
	"severity": 4,
	"message": "Argument '1' passed to echo() is expected to be of type string, bool given",
	"source": "PHP",
	"startLineNumber": 9,
	"startColumn": 6,
	"endLineNumber": 8,
	"endColumn": 15
}]

"bool given" is not true.

Expecing problem at line 5 and 6, accessing const[undefined].
Expecting problem at line 6, undefined $bar.

weissersand

weissersand Remember

JakubMisek

weissersand Thank you for reminding me.

The issue has been closed; and the other message seems to be unrelated. May I ask to file a new issue?

But from what I see, the following code does not make much sense

$a = ['foo' => true];
echo $a['bar'];

$a['bar'] is not specified, so the editor can only "guess"