No error/warning on incorrect argument type

KrisReeves

I've simplified this repro case down to just this:

I expected the argument to have a wavy red underline telling me that the argument I'm passing is incorrect. It does know the type:

My original use-case was typing an argument with a template type from an abstract class, e.g.:

<?php

/**
 * @template T
 */
abstract class Outer {
  /** @param T $arg */
  abstract function do_thing($arg): void;
}

/**
 * @extends Outer<int>
 */
class Child extends Outer {
  /** @param int $arg */
  function do_thing($arg): void {
  }
}

so it'd be nice if that worked too, but the very basic case seems pretty weird.

JakubMisek

Thank you for the test case.

It is up to a discussion I guess; we respect the declare(strict_types=1); directive. The implicit conversion from string to int is fine without it.

KrisReeves

Aha. I was unaware that existed - I'll give it a go (after I get done bashing my head against this current PHPUnit problem....)

I can understand why it would be troublesome to determine statically if a string meaningfully contains a number, I guess the surprising thing here to me is that "an implicit conversion from string to int is fine" at all :)

JakubMisek

KrisReeves It is valid only if the string can be parsed as a number :) we should add that diagnostic though.

// without declare(strict_types=1);
do_thing($a_string_value); // hard to tell
do_thing("123"); // valid
do_thing("helo"); // fatal error

KrisReeves

Funny, I sort of assumed it would do the same as intval(), which will just return 0 for everything

JakubMisek

KrisReeves yep, I'm struggling with the php behavior all the time like this :)

The check for passing string value to int parameter has been implemented. The feature will be available in the next update.