stubs for php trader extensions is not correct

rabol

Hi
in a discussion with the Larastan team I was informaned that the sub for the php trader extension is not correct

<?php // generated by https://www.devsense.com/

/**
 * Exponential Moving Average
 *
 * @param array $real Array of real values.
 * @param int $timePeriod Number of period. Valid range from 2 to 100000.
 * @return array Returns an array with calculated data or false on failure.
 */
function trader_ema($real, $timePeriod) { /* function body is hidden */ }

as far as I understand the @return should be something like array|false as that is what the function can return

i tried to find the stub file, but failed so far

JakubMisek

rabol This is taken directly from the manual:

https://www.php.net/manual/en/function.trader-ema.php

Our stubs are parsed from the php.net manual pages in all their languages, but we can override if some information is incorrect.

JakubMisek

We'll update it in our IntelliSense.

The manual page should be fixed as well though.

rabol

I can see the confusion... the declaration say :array, but the description say array or false on failure

I made a PR to PHPStan, which is now included so PHPStan now knows about array|false

is it possible to add my own stubs that phptools then will pickup and use ?
and if yes, how ?

JakubMisek

rabol rabol the stubs are built-in (and we'll update the trader in the next update), but you can override it with your custom stubs:

create a .php file(s) with your stubs anywhere in workspace (or add the composer package with 3rd party stubs)
disable our built-in stub you want to override:
- VSCode Command Palette: > PHP: Workspace Stubs
- search for trader
- uncheck trader and click ok