Class property // comment after goes to below it after format?

JimNayzium

Here is my desired output

class MyClass {
    private string $myVar; // note about myVar
    private string $myOtherVar; // not about myOtherVar
 }

But what I get after I format is this.

class MyClass {
    private string $myVar; 
    // note about myVar
    private string $myOtherVar; 
    // not about myOtherVar
 }

I have read over all the spacing and newline options and LOOOOOOVE it all give or take a few little headaches like this.

Am I missing something very simple?

JakubMisek

JimNayzium Thank you for the question!

I have tried your sample, and with the default settings, it's not moving my comments. So I guess there is some changed option that causes it. What are your settings?

JakubMisek

@JimNayzium with the default settings, the code is formatted all alright. May I ask what settings you have changed?

JimNayzium

Man, chalk me up for lamest response time ever.
I will say, your extension works so well, it kinda made me forget to even check up on any issues!
I am sure something in my settings is causing it most likely!
But it still did it as I checked for this reply, and pasting my settings in here made me look over the settings.
AND I made it stop doing it!
Commenting out the class property blank lines line fixed it.

    "php.format.rules.blankLinesAfterClassBody": 0,
    "php.format.rules.blankLinesAfterFunction": 1,
    "php.format.rules.blankLinesAfterMethod": 1,
    "php.format.rules.blankLinesAfterNamespace": 1,
    "php.format.rules.blankLinesAfterOpenTag": 0,
    "php.format.rules.blankLinesAfterUseStatements": 0,
    "php.format.rules.blankLinesAroundClassConstant": 1,
    // "php.format.rules.blankLinesAroundProperty": 0,
    "php.format.rules.blankLinesBeforeClass": 2,
    "php.format.rules.blankLinesBeforeClassBody": 0,
    "php.format.rules.blankLinesBeforeFunction": 1,
    "php.format.rules.blankLinesBeforeMethod": 0,
    "php.format.rules.blankLinesBeforeFunctionBody": 1,
    "php.format.rules.blankLinesBeforeMethodBody": 1,
    "php.format.rules.blankLinesBeforeNamespace": 0,
    "php.format.rules.blankLinesBeforeReturnStatement": 1,
    "php.format.rules.blankLinesBeforeUseStatements": 0,
    "php.format.rules.maxBlankLines": 2,
    "php.format.rules.booleanConstantCasing": "lowercase",
    "php.format.rules.spaceAfterCast": true,
    "php.format.rules.spaceAfterUnaryNot": true,
    "php.format.rules.spaceAroundConcatenation": true,
    "php.format.rules.spaceBeforeColonInControlStatements": true,
    "php.format.rules.spaceBeforeParenthesesInArrowFunctions": true,
    "php.format.rules.spaceBeforeParenthesesInControlStatements": true,
    "php.format.rules.spaceBeforeParenthesesInDeclarations": false,
    "php.format.rules.alignConsecutiveAssignments": true,
    "php.format.rules.alignConstants": true,
    "php.format.rules.alignEnumCases": true,
    "php.format.rules.alignMatchArmBodies": true,
    "php.format.rules.alignProperties": true,
    "php.format.rules.arrayInitializersAlignKeyValuePairs": true,
    "php.format.rules.arrayInitializersNewLineAfterLastElement": true,
    "php.format.rules.arrayInitializersNewLineBeforeFirstElement": true,
    "php.format.rules.arrayInitializersWrap": "onEveryItem",
    "php.format.rules.callParametersNewLineAfterLeftParen": false,
    "php.format.rules.callParametersNewLineBeforeRightParen": true,
    "php.format.rules.callParametersWrap": "onEveryItem",
    "php.format.rules.chainedMethodCallsWrap": "onEveryItem",
    "php.format.rules.declCompactEmptyBody": true,
    "php.format.rules.declKeepRightParenAndOpenBraceOnOneLine": true,
    "php.format.rules.declParametersNewLineAfterLeftParen": true,
    "php.format.rules.declParametersNewLineBeforeRightParen": true,
    "php.format.rules.declParametersWrap": "onEveryItem",
    "php.format.rules.forStatementNewLineAfterLeftParen": true,
    "php.format.rules.forStatementNewLineBeforeRightParen": true,
    "php.format.rules.forStatementWrap": "onEveryItem",
    "php.format.rules.ifStatementNewLineAfterLeftParen": true,
    "php.format.rules.ifStatementNewLineBeforeRightParen": true,
    "php.format.rules.implementsListWrap": "onEveryItem",
    "php.format.rules.whileStatementNewLineAfterLeftParen": true,
    "php.format.rules.whileStatementNewLineBeforeRightParen": true,
    "php.format.rules.openBraceOnNewLineForFunctions": true,
    "php.format.rules.keepFunctionsOnOneLine": true,
    "php.format.rules.openBraceOnNewLineForLambdas": false,
    "php.format.rules.blankLinesBetweenUseTypes": 1,
    "php.format.rules.indentHeredoc": true,
    "php.format.rules.inlineHeredoc": true,
    "php.format.rules.blankLinesAfterClass": 0,
    "php.format.rules.blankLinesAroundEnumCase": 1,`

MiloslavBeno

Hi Jim,

Thank you for providing us with the settings and especially for pointing out the one that caused the issue — that will make it an easy fix.

Thanks again!

JimNayzium

MiloslavBeno You bet! LOOOOOVE this extension! I would not be able to support my addiction/hobby of trying to write a Laravel application that will change the fantasy football world forever! 😄 HAHAHA.

MiloslavBeno

Love to hear that :-D

btw. we've fixed the issue, so the next update should be fine ;-)

Thanks again for letting us know!