How to avoid an error that is actually not an error

rabol

how can I avoid this 'error'


Argument '1' passed to __construct() is expected to be of type App\Models\UserDoc, Illuminate\Database\Eloquent\Collection given

Here is the code:

        $userDoc = UserDoc::find(Crypt::decrypt($this->encryptedData));
        event(new UserDocReceiverHasSignedEvent($userDoc));

Technically I can somewhat understand the error because the doc says this:

  /**
     * Find a model by its primary key.
     *
     * @param  mixed  $id
     * @param  array|string  $columns
     * @return ($id is (\Illuminate\Contracts\Support\Arrayable<array-key, mixed>|array<mixed>) ? \Illuminate\Database\Eloquent\Collection<int, TModel> : TModel|null)
     */

The comment contradicts the return value a little IMO

but in reality find() always return one model or null - yes, if called with an array it can return a collection

JakubMisek

rabol, thank you for the test case!

~~What is the return type of Crypt::decrypt() ?~~ mixed
What version of Laravel do you have? Mine (11.3.1) has a different @return annotation:

    /**
     * Find a model by its primary key.
     *
     * @param  mixed  $id
     * @param  array|string  $columns
     * @return \Illuminate\Database\Eloquent\Model|\Illuminate\Database\Eloquent\Collection|static[]|static|null
     */

JakubMisek

rabol, we get this wrong:

$c should be both Collection | int in this case - will be fixed.

JakubMisek

@rabol, the issue will be fixed in the next update. It was a specific case of conditional @return type and type of $id (mixed).

rabol

JakubMisek Thanks a LOT!