Parameter hints not working in PHP 1.58

TheDevDoctor

With PHP 1.58 nothing happens when I hit ctrl+shift+space.
When I install version 1.57, parameter hints work fine.
Any idea what's going on?

JakubMisek

TheDevDoctor, thank you for reporting the issue.

May I ask for

the log in OUTPUT / "PHP (Language Server)"?
your OS

TheDevDoctor

Windows 10.
It happens only on functions without PHPDoc comment, PHP version is set to 7.3.33 btw.
If I add a completely empty PHPDoc comment, then the parameter hints work again.

Output of language server:

[Info - 9:58:08 AM] PHP Language Server Started (PID: 28250)
[Info - 9:58:10 AM] Loaded 8 package(s) from cache in 00:00:01.1535246.
[Info - 9:58:12 AM] Processing packages in /var/www/html/appname/vendor/composer/installed.json ...
[Info - 9:58:12 AM] Processing done in 00:00:00.0034037.

JakubMisek

TheDevDoctor, thanks!

So it happens for functions defined in vendor folder, without a PHPDoc comment?

Or any function anywhere?

It may be a known bug with cache (working on it) - please try running the command:

Clear /vendor/ cache ...

MaximeFandard

Hi, I also have the same issue. It happens for user defined functions that don't have phpdoc information, and php native functions that have multiple definitions (I think because I have phpstan.phar and phpunit.phar in the root of one of my projects, the function signatures get parsed, but maybe also polymorphic functions are like that).

This bug occurs on brand new projects also so don't know if cache is involved.

I can see the function signature if I hover the function name though.

PHP Language Server output is not very verbose:
[Info - 15:47:03] PHP Language Server Started (PID: 25888)

Crossing my fingers for a fix, I feel naked without Ctrl + Shift + Space.

Thanks

TheDevDoctor

So it happens for functions defined in vendor folder, without a PHPDoc comment?
Or any function anywhere?

Clearing the vendor cache does not work.
It happens in any function, even in the same class.

Right now I can only get it to work with a PHPDoc that has a description, which is inconsistent with what I saw earlier.
I have reinstalled the plugin and restarted vscode completely, and it still happens.
I added some images to clarify what happens now. Thanks for looking in to it.

JakubMisek

TheDevDoctor, thank you for the screenshots.

You're right, will be fixed asap.

JakubMisek

Found an undocumented bug in vscode language server protocol.

Will be fixed in the next update of PHP extension.

Thanks!