Deleted function ignored

pmo

Hi, I've been using devsense in VSCode for quite a while and I noticed one strange behavior. I have a Laravel project, where I have a model Invoice with some functions. I had a function for managing tax, which I removed and forgot to remove all references to it. To my surprise, this function is not highlighted at all. When I hover over it, it doesn't show modal as before (which is correct), but there is no underline, which I believe is wrong. So some external functions are underlined right after I finish typing, but $this->modifyTaxes() is not highlighted, even if it's from the same class? Is this a feature?

JakubMisek

pmo, thank you for your question.

May I ask for a screenshot or a sample code?

Is modifyTaxes() the removed function?

pmo

Yes, here's another example with more readable code. In PHPStorm, this is working correctly and it underlines this function, but here it looks normal while it's not, only way to identify the problem is to hover and wait if a description pops up and if it doesn't, the function is missing.

JakubMisek

Thank you for the screenshot. It appears that the code is not being analyzed at all.

May I ask you to check if code analysis is enabled?

Background Code Analysis

"opened"

pmo

OK so I didn't have it enabled, but setting it to "opened" it did nothing. Setting it to "all" I can see 127 issues in my workspace, but 0 in Invoice.php, it still has no underline or error info.

JakubMisek

pmo thanks for checking that;

Navigation to the function (go to definition / F12) does nothing either?

pmo

well, it shows "No definition found" because the function is not there, it was removed and IDE is not showing any error about using that function in other functions from that class. That's why I put the question mark in Outline :) Shouldn't it show any kind of error? I have a lot of unreachable code problems with "All", which is reachable, but that's not a big deal. Showing error on missing function is an expected behavior here, isn't it?

JakubMisek

pmo, just checking how much the IDE is confused :)

May I ask for a sample of a false unreachable code warning? FYI, you can disable warnings using settings.json or .editorconfig (https://docs.devsense.com/vscode/problems/suppressing-diagnostics/)
is there another error in the file? That might suppress warnngs about undefined functions

pmo

Sample for the unreachable code, which I believe is incorrect (but maybe I understand my own code incorrectly)

if (!$request->has('secret_key')) {
    Log::error('Superfaktura callback error: Secret key is missing');
    throw new \Exception('Invoice ID is missing');
}
if ($request->get('secret_key') != config('constants.superfaktura.callback_secret')) {
    Log::error('Superfaktura callback error: Invalid secret key');
    throw new \Exception('Invalid secret key');
}
if (!$request->has('invoice_id')) {
    Log::error('Superfaktura callback error: Invoice ID is missing');
    throw new \Exception('Invoice ID is missing');
}

//get invoice_id or profoma_invoice_id
$invoice = Invoice::where('invoice_id', $request->get('invoice_id'))->orWhere('proforma_invoice_id', $request->get('invoice_id'))->first();

Here the whole line for $invoice is underlined with PHP0419 error. But thanks for the tip, I updated my .editorconfig.

Regarding the missing function file, there is no error at all, no warning, notices .. nothing, but it should show at least 2 functions missing.

JakubMisek

pmo, thank you;

I don't have unreachable code warning in this code sample - maybe there is some context missing?
isn't there "problems.exclude" setting in your settings.json? this almost looks like diagnostics are turned off for this file

pmo

I only have "php.problems.excludeGitIgnore": true nothing else anywhere.

I figured out the unreachable code, my mistake (one more throw exception above, which was not in a condition) ... still looking for the missing function errors to hit me :)

JakubMisek

pmo I guess the file isn't specified in .gitignore?

pmo

OK since I started this thread I fixed lots of code after previous dev, mostly thanks to enabling the code analysis in the whole workspace. I fixed most of issues OR added them to ignores.

What I still don't have fixed is the original question - shouldn't non-existing function in a class trigger a warning/error when used in the same class or anywhere else? As you can see in the previously attached screenshot, the function is not in the class, yet $this->functionName is not underlined or anything. As it doesn't exist, the modal box won't show and that's only way to figure out something is wrong.
Is this a feature or a bug? Is the only option to detect these to run PHPStan or similar tool?

JakubMisek

pmo Thank you for the update.

If the error is not underlined, the file may be excluded from code analysis.

please check the file does not have something like // @phpcs:ignore
in the VSCode's settings.json, there is no "php.problems.exclude": ... setting
quick "smoke test": if you write something like strlen(); Does it underline it with a "missing argument" warning? (to see if diagnostics are enabled for this file)

pmo

there are no @phpcs:ignore rules
I do have php.problems.exclude .. but only recently added for unreachable code..
strlen() is underlined, I also see the "problem" in list, Missing argument $string for strlen(), PHP0423
Errors are correctly underlined for core PHP functions and even functions from external classes, but not when I reference function from the same class using $this. Strangely, self:: seems to work fine

JakubMisek

pmo Thank you for the details. I'll try to replicate the issue on my machine.

JakubMisek

pmo note - we don't report unknown methods on $this in trait or if parent class is unknown.

pmo

Well, that s***s a bit :) my class extends Model (Laravel), so because of that, $this is ignored even if the method used in same class and file is not found. It is what it is, but for me this doesn't sound right. Such error shouldn't be ignored if it comes from the same class. I'll try to find a different way to check these errors before I commit..

JakubMisek

pmo only in trait - because you never know who is using that trait.

pmo

yes that makes sense, but here in this specific scenario, I have a file Invoice.php in app folder, which only has Invoice class in it, which extends Model. It's not trait and it doesn't underline non-existent function when referencing via $this and I don't get why. Model uses trait ForwardsCalls and that's it. Does that mean, that when I extend a Model in Laravel, it will break highlighting of such errors in my code, because parent class uses a trait? As I mentioned before, this works fine in PHPStorm ..

JakubMisek

pmo no - only method inside a 'trait' after '$this->'.

Example:

trait T {
 function foo() {
   $this->something(); // Won't be underlined
 }
}

class X {
  use T;
  function bar() {
    $this->anything(); // Will be (should be) underlined
  }
}

JakubMisek

pmo there might be some edge case, for example the same class is defined more times in your workspace?

i.e. class Invoice is there twice, or you have more Laravel projects in the same workspace?