Formatter BUG - Trailing commas being applied to PHP 7.4 project

Erick

I recently had to make a change on a legacy PHP 7.4 project, and when I format the code (I do it on save), the formatter adds trailing commas into function calls and arrays. My composer.json has the php 7.4 version, and I also changed it in the bottom right corner to the 7.4 version.

Erick

Note: Actually, trailing commas in arrays are supported in PHP 7.4. The problem here is on function calls.

Thank you!

Erick

Sorry again. I wrongly said in "function calls" but I meant function definitions, like this:

function get(
        string $p1,
        string $p2,
        string $p3,
    ): string {
//...

}

The trailing comma after $p3 should not be there.

Sorry again for the confusion.

MiloslavBeno

Thanks Erick!

It makes sense for the formatter to check the PHP version and avoid adding a trailing comma in function parameter declarations when targeting PHP < 8.0, even if the addCommaAfterLastDeclParameter setting is enabled. We’ll look into improving this so the formatter becomes version-aware.

In the meantime, to prevent this behavior, you can explicitly disable the setting like this:

Option 1 – .editorconfig

[*.php]
php_format_add_comma_after_last_decl_parameter = false

Option 2 – settings.json

"php.format.rules.addCommaAfterLastDeclParameter": false

Thank you

MiloslavBeno

Hi,

Thanks again for the suggestion. We'll be checking this in the next update - so formatter will not add a comma when active PHP does not support the syntax.

Please let us know if you'd run into anything else.

Thank you!