Zed IDE, Neovim, and language server support

ColinMollenhour

I did finally get it working with opencode using this config:

{
  "$schema": "https://opencode.ai/config.json",
  "lsp": {
    "devsense-php": {
      "command": ["/home/colin/.local/share/pnpm/devsense-php-ls", "--stdio"],
      "extensions": [".php", ".phtml"],
      "initialization": {
        "0": "{\"name\":\"Colin...***REDACTED***",
        "php.version": "8.2"
      }
    }
  }
}

Tested with opencode debug lsp diagnostics --print-logs ./index.php

Thanks again!

JakubMisek

ColinMollenhour so it was running a wrong binary ? If the full path to the devsense-php-ls solved it

ColinMollenhour

JakubMisek I think I wasn't passing the initialization correctly. Also Crush and OpenCode don't use the full capabilities of the LSP, they mostly just get problem hints. So I'm not entirely sure if it was using the absolute path or not - I think it wasn't the problem but I just left it to have fewer possible issues.

CharlieJ

This is awesome! Thank you, I switched to Zed and it's been fantastic using Devsense Phptools.

My only issue currently is this error, weirdly it doesn't show up on Cursor (And I did disable intelephense and phpactor in the Zed config)

(Off-topical, can my name be changed to "Charlie J" please as it doesn't let me)

JakubMisek

CharlieJ thank you!

It looks like your where method is defined in some kind of ide-helper (and incorrectly without the default values), because the signature is a bit different from what I have in vanilla Laravel:

Where does it navigate you, if you go to the definition of where (F12) ?

CharlieJ

JakubMisek Apologies for the delay!

It takes me to vendor/laravel_ide/model_helpers.php, this line:

@method static \Illuminate\Database\Eloquent\Builder<Country>|Country where(\Closure|string|array|\Illuminate\Contracts\Database\Query\Expression $column, mixed $operator, mixed $value, string $boolean)

I currently use laravel-ide-helper to help Zed with more project specific stuff

CharlieJ

My issue above seemingly seems to be ok, may've been a faulty ide-helper setup, not sure.

Also, would LOVE if you guys could support this https://community.devsense.com/d/869-auto-remove-unused-use-lines-on-save/2 but in Zed.

I have a key bind for the organise imports option in Zed, would just need to hook in.

JakubMisek

CharlieJ does this work? We can take a look in more details, why it's not being triggered on zed

https://zed.dev/docs/configuring-zed#:~:text=Organize%20imports%20on%20save

CharlieJ

JakubMisek Annoyingly not :( doesn't seem to do anything for PHP, works for JS and Vue though

JakubMisek

CharlieJ found it; we have a bit different naming of those settings (old naming did not allow to just sort, and it caused problems for people who periodically save files ...)

    "source.organizeImports": true,      // sort uses
    "source.sortImports": true,          // sort uses (same as "source.organizeImports")
    "source.sortAndRemoveImports": true, // removes unused uses and sorts them

More at https://docs.devsense.com/vscode/code%20actions/organize-uses/#remove-and-sort-uses-on-save (VSCode Settings)

CharlieJ

JakubMisek You're fantastic, this worked! Thank you, for anyone else who visits this, all I added was this to my Zed settings:

    "languages": {
        "PHP": {
            "code_actions_on_format": {
                "source.sortAndRemoveImports": true
            },
            // ... other options ...
            }
        }
    },

I'm sure a better way to do it but it's worked for me :)

That where bug has came back with the ide-helper, weirdly no issues with Cursor so I suspect its the PHP language server on Zed perhaps?

Cursor:

Zed:

This is the generated mixin if it helps for debugging: https://gist.github.com/charnary/0dd400e35690267b316e5d8ded8eb29f

JakubMisek

CharlieJ awesome! we'll add it to the documentation soon.

The generated mixin has incorrect parameters (missing initial values):
https://gist.github.com/charnary/0dd400e35690267b316e5d8ded8eb29f#file-ide-helper-mixins-php-L52

infodroid

I would really like to switch from Vscode to Zed but I've some issues.

First and foremost I'm working with a lot of legacy code, functions and classes are in *.inc files. In Vscode I've added them as PHP files and they are being indexed by phptools. In Zed I've added them as well ("file_types": {"PHP": ["inc"]}) and they are being recognised by Zed as PHP files but phptools is not indexing them and I've a lot of "use of unknown class/function" errors and no intellisense/codelens.

For testing purposes I've renamed some from *.inc to *.php and then they are getting indexed, just opening them works as well but this ist not a solution for me.

Can this somehow be configured with initialization_options?

JakubMisek

infodroid, sorry for the delay!

Good point - we'll need to take a look how Zed associates languages and extensions.
As a quick workaround, add the following initialization_options:

"lsp": {
    "phptools": {
      "initialization_options": {
        "files.associations": { "*.inc": "php", "*.php": "php" }
      }
    }
  }

pjv

Is there a way to request a trial license for using phptools premium in Zed?

JakubMisek

pjv, hello pjv! Thank you for the request, and sorry for the delay. I've sent you an email with the key.

We don't have a workflow for requesting a Trial license right inside Zed yet. As a workaround, you can request a trial from within VSCode, and, without activating it in VSCode, use it in Zed.

Simon2

JakubMisek

Is support for Sublime Text also planed for the Future maybe ?

JakubMisek

Simon2, thank you for the question.

Sublime Text is supported (unofficially) in the same way as "phpactor" (https://lsp.sublimetext.io/language_servers/#phpactor)

install npm package https://www.npmjs.com/package/devsense-php-ls globally
npm i -g devsense-php-ls
add the client configuration in Sublime with the "command": ["devsense-php-ls", "--stdio"]

« Previous Page