files.exclude issue

Jean-FrancoisHIVERT

Hi,

It seems the configuration files.exclude does not work correctly to avoid references/symbols.

This is my config:

    // Exclude files in the VS explorer
    "files.exclude": {
        /* -------------------------------------------------- */
        "**/.angular": true,
        "**/bin": true,
        "**/build": true,
        "**/dist": true,
        "**/node_modules": true,
        /* -------------------------------------------------- */
        "phpclishell/vendor": false,
        "phpclishell/phpunit": false,
        /* -------------------------------------------------- */
        /* -------------------------------------------------- */
        "phpclishell/development": true,
        "phpclishell/documentation": true,
        /* -------------------------------------------------- */
        "phpclishell/tools": true,
        "phpclishell/src/**/tools": false,
    },
    // Exclude folders in the search results
    "search.exclude": {
        "**/.angular": true,
        "**/bin": true,
        "**/build": true,
        "**/dist": true,
        "**/node_modules": true,
        "phpclishell/bin": true,
        "phpclishell/build": true,
        "phpclishell/tools": true,
        "phpclishell/vendor": true,
        "phpclishell/phpunit": false,
        "phpclishell/development": true,
        "phpclishell/documentation": true,
        // Duplicated location, see phpCliShell/tests
        "phpclishell/phpunit/tests": true,
    },

I have a reference for a trait function to the file phpclishell/development/src/phpCliShell/Application/Netbox/Routine/Archives/AbstractNewLeafMasterInterco.php

With the configuration "phpclishell/development": true, we should not have this reference.

Thank you for the fix.

Related to these tickets:

JakubMisek

Jean-FrancoisHIVERT I think if there are no better results, we show the symbols from search.exclude anyways, let me check

JakubMisek

Jean-FrancoisHIVERT are you referring to the code lens "references" above the declaration?

In that case, you are right, we don't cross-check with search.exclude setting.

Jean-FrancoisHIVERT

Yes, I confirm it is related to this feature reference for functions for example.

You said in this ticket https://github.com/DEVSENSE/phptools-docs/issues/780#issuecomment-2781399853

"files.exclude" used to ignore files from indexing (and search).
"search.exclude" will be newly supported - makes the files ignored within find references and workspace symbols.

So, how can we avoid some reference to a specific folder with the last version of your tool?

"phpclishell/development": true, is in the "files.exclude" settings so why this folder is not ignored?

JakubMisek

Jean-FrancoisHIVERT we just missed this case; currently in version 1.60 we respect search.exclude when searching for references using the command "find references" (Shift+F12). We simply forgot about code lenses.

Will be implemented.

JakubMisek

fixed in the next update, thank you!