Tooltip issue with __get method

Jean-FrancoisHIVERT

Hi,

There is no tooltip for the type when we use __get(...) method and this one returns a specific type:
Related to the issue https://community.devsense.com/d/2255-specific-return-type-for-get_

<?php

declare(strict_types=1);

namespace Devsense\Builtin;

use ArrayObject;

final class MyClass
{
    public function __get(string $name): ArrayObject
    {
        return new ArrayObject();
    }
}

$a = new MyClass();

/**
 * Test property should be an ArrayObject
 * A tooltip with the type of test should be displayed
 */
$a->test->getArrayCopy();

// This code works
$array = $a->data;
$array->getArrayCopy();

// This code does not work
$data = $a->{'data'};
$data->getArrayCopy();

There is not any tooltip for ->test but it seems it is correctly resolved.
Another issue when we use ->{'...'}, it seems it is not correctly resolved.

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT, thank you for the code sample.

We should probably behave consistently with magic methods __call.

1/ $x->test is not defined, and we incorrectly don't show anything. Historically, we expected that users introduce their dynamic properties using PHPDoc /** @property $test */ above the class, but it's not always the case.
2/ ->{...} is an indirect property access that (mostly) can't be resolved statically, so we treat it as mixed. In this special case, we can improve, though.

Jean-FrancoisHIVERT

For both cases, you can improve the behavior when the @property is missing, with these conditions:

A magic __get(...) method is defined
The magic __get(...) method does not return mixed but returns a specific type

The goal is to work with collection and dynamic keys/properties.