Inline doc to define variable types does not work

Jean-FrancoisHIVERT

Hi,

Found the following bug with multiple inline doc @var ...:

<?php

declare(strict_types=1);

namespace Devsense\Builtin\Doc;

use ArrayObject;

final class MyClass
{
    public function __get(string $name): mixed
    {
        return new ArrayObject();
    }
}

$a = new MyClass();

/**
 * Both variables must be resolved
 *
 * @var ArrayObject $array
 * @var ArrayObject $data
 */
$array = $a->data;
$array->getArrayCopy();

$data = $a->{'data'};
$data->getArrayCopy();

$data is not correctly resolved.

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT thank you for reminding me.

Yes, currently the editor respects a doc block above the statement.

In the sample above, @var ArrayObject $data has no effect, because it does not correspond to the code below it, and then the line $data = $a->{'data'}; "overwrites" this information. The following would work:

/** @var ArrayObject $array */
$array = $a->data;
$array->getArrayCopy();

/** @var ArrayObject $data */
$data = $a->{'data'};
$data->getArrayCopy();

But you are right, we should remember the type from the doc block, and respect it - I'm adding it to the list.

Jean-FrancoisHIVERT

@JakubMisek any update about this issue please?
Maybe it is a feature request?