Wrong type since few releases

Jean-FrancoisHIVERT

Hi,

I have an issue for few releases ago.
I did not have these errors before but now there is an issue and some variables have the wrong type:

The nextAddress() method returns false|static but it seems your tool keeps bool type.
I think it started when you implemented the false type to avoid to get bool when we return false only.
I believe you implemented false and true to improve typing.

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT, thank you for reporting this.

The warning does not make much sense. Isn't there another class Address in your workspace? Because it seems they are mixed up.

Jean-FrancoisHIVERT

@JakubMisek it does not make sense yes because few lines above I don't have any warning:

JakubMisek

Jean-FrancoisHIVERT this is weird.

May I ask to paste the following code somewhere in between the problematic code:

$next = $address->nextAddress();
var_dump( $next );

and please try a mouse tooltip over the $next, if the type is correct.

I'm always open to a quick remote desktop session, if you are willing to, and you have a favorite remote desktop tool.

Jean-FrancoisHIVERT

Type ok:

Wrong type:

Check nextAddress call:

JakubMisek

Jean-FrancoisHIVERT thanks! omg, I found it.

The $this->assertFalse() has @phpstan-assert false $condition annotation, which we take into account way too much.

Sample test (inside PHPUnit test case):

        $a = rand() ? false : new ArrayObject();

        /** @trace $a */

        $this->assertFalse($a);

        /** @trace $a */

Types are broken after assertFalse():

Jean-FrancoisHIVERT

Thank you so much.

I understand now why I get errors for unit tests only, sorry I forgot to give you this information.

Jean-FrancoisHIVERT

@JakubMisek Just tested the last release and we have the same issue with $this->assertNull(...), it change the type of the variable to null, like for assertTrue and assertFalse.

Thank you for the fix.

Jean-FrancoisHIVERT

Just see, with assertTrue and assertFalse, we have some issues again.

JakubMisek

To be clear, it is correct behavior.

assertTrue, assertFalse, and assertNull will change the variable to the corresponding type.

The issue is, the type is not reset after the variable is re-assigned.

Jean-FrancoisHIVERT

@JakubMisek ok so with this code:

It is expected to have the error? but after to call load() the tags attribute is not null.
I test with $this->assertInstanceOf(Tags::class, $location->tags); so tags should be Tags::class and not null.

JakubMisek

Jean-FrancoisHIVERT, thank you.

I see, the assertInstanceOf() should make it right, but it has a weird annotation which we don't support yet:

/**
 * @phpstan-assert =ExpectedType $actual
 */

Will be implemented.

JakubMisek

Jean-FrancoisHIVERT, update: the version 1.63.18172 implements the proper behavior. Please let me know if there is anything else.

Jean-FrancoisHIVERT

@JakubMisek It seems it works now, I just have one issue:

I think it is an issue because it is not the same behavior between these lines: