Issue with interface, IteratorAggregate and template

Jean-FrancoisHIVERT

Just found an issue related to the generics and templates:

<?php

declare(strict_types=1);

namespace Devsense\Builtin\Iterator;

use ArrayIterator;
use IteratorAggregate;
use stdClass;

/**
 * @template T
 * @extends IteratorAggregate<T>
 */
interface MyInterface extends IteratorAggregate {}

/**
 * @implements MyInterface<stdClass>
 */
final class MyClass implements MyInterface
{
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator();
    }
}

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT thank you! will be fixed.

Jean-FrancoisHIVERT

@JakubMisek Hi, it seems with the last pre-release version, the issue is not fixed, I have now more than 400 errors instead of 150.

JakubMisek

Jean-FrancoisHIVERT, do you have another test case? Tests we have are ok now:

Jean-FrancoisHIVERT

@JakubMisek Yes:

<?php

declare(strict_types=1);

namespace Devsense\Builtin\Iterator;

/**
 * https://community.devsense.com/d/2513-issue-with-interface-iteratoraggregate-and-template
 */

use ArrayIterator;
use IteratorAggregate;
use stdClass;

/**
 * @template T
 * @extends IteratorAggregate<T>
 */
interface MyInterface extends IteratorAggregate {}

/**
 * @implements MyInterface<stdClass>
 */
final class MyClassA implements MyInterface
{
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator();
    }
}

final class MyClassB implements MyInterface
{
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator();
    }
}

final class MyClassC implements IteratorAggregate
{
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator();
    }
}

/**
 * @implements MyInterface<stdClass>
 */
abstract class Base implements MyInterface {}

final class MyClassD extends Base
{
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator();
    }
}

JakubMisek

Jean-FrancoisHIVERT thank you!

It gets confused with another feature, where you can use @extends on a trait to annotate its parent class.

Will be fixed properly.

Jean-FrancoisHIVERT

@JakubMisek thank you.

You mean we can use @extends with trait? like with a parent class (abstract)?
It will be useful to be able to use generics with trait, I was not aware it was possible.

Could you fix these issues please?

It could be related to this one. Thank you.

Jean-FrancoisHIVERT

@JakubMisek it works now thank you.