Warning for dynamic properties

haskellmcravin1

It would be very helpful to be able to warn when a dynamic property is used with .editorconfig similarly to how Im warning for unoptimized function calls.
php_diagnostic_php6616 = warning

Am I missing something? I tried using php_diagnostic_php0416 = warning

JakubMisek

haskellmcravin1, hello,

Dynamic properties should be reported already (if the object type can be inferred).

In the case of a dynamic object with __get or __set, the warning is PHP6602 unless the property is explicitly defined with @property PHPDoc tag.

The full list of diagnostics can be found on https://docs.devsense.com/vscode/problems/diagnostics/

JakubMisek

Note: this diagnostic will be slightly improved in the next update - now we check it more strictly when READING the property, but we don't report it when ASSIGNING to the property - which is wrong, and we didn't notice it.

haskellmcravin1

90% of the properties in my classes do not use __set and __get.

I suppose I'm talking specifically about assignments? That seems to sidestep the warning. Sometimes in a refactor old properties with similar names are left and easily missed.

So I guess consider this a feature request... it's caught at compile time and emits a warning, but more immediate IDE feedback would be helpful.