Formatting Bug

Frenwork

php.format.rules.keepControlStatementsOnOneLine

Before formatting:

class foo
{
    function bar()
    {
        if (true) return;
    }
}

After formatting:

class foo
{
    function bar()
    { if (true) return;
    }
}

Formatting without:

class foo
{
    function bar()
    {
        if (true)
            return;
    }
}

MiloslavBeno

Hello,

Thank you for reporting this. It seems this might be related to another setting since it doesn't happen to us just with

php.format.rules.keepControlStatementsOnOneLine

May I ask for all your php formatting settings?

Thank you!

Frenwork

MiloslavBeno
Found out its this combination:

{
    "php.format.rules.blankLinesBeforeMethodBody": 0, // even with 1-3 its buggy
    "php.format.rules.keepControlStatementsOnOneLine": true,
}

MiloslavBeno

Thanks! That's it, we will fix that ASAP.

MiloslavBeno

The fix is present in the upcoming update!

Thank you

Frenwork

Awesome, its fixed. I really like your work.

MiloslavBeno

Hi, that’s great to hear! Happy to help.

If you have a moment, would you mind leaving us a quick rating or a short review on the VS Code Marketplace?

Most people only head there when they have a complaint, so a positive note from someone who actually enjoys the daily experience helps us immensely and gives a more balanced view for others.

Thanks for the support!