Regression: Issues with ArrayObject

Jean-FrancoisHIVERT

Hi,

I found these issues:

<?php

declare(strict_types=1);

namespace Devsense\Builtin\ArrayObject;

use ArrayIterator;
use ArrayObject;
use IteratorAggregate;

class Test implements IteratorAggregate
{
    public function get1(): ArrayObject
    {
        $store = new ArrayObject([], ArrayObject::ARRAY_AS_PROPS);
        $store->attr = true;
        return $store;
    }

    public function get2(): ArrayObject
    {
        $store = new ArrayObject([
            'attr' => true,
        ], ArrayObject::ARRAY_AS_PROPS);

        return $store;
    }

    public function getIterator(): ArrayIterator
    {
        $a = new ArrayObject();
        return $a->getIterator();
    }
}

final class MyArray extends ArrayObject
{
    /**
     * https://community.devsense.com/d/2494-extend-of-builtin-classes-and-override-methods
     */
    public function exchangeArray(array|object $items): array
    {
        return [];
    }
}

$test = new Test();
$object = $test->get1();
$attr = $object->attr;

$object = $test->get2();
$attr = $object->attr;

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT, thnak you.

But I can't repro the issue in the latest release (1.70.18915) or pre-release (1.70.18959).

Please check if you don't have any (unnecessary) stubs with class ArrayObject in your workspace - they may have invalid function signatures.

Jean-FrancoisHIVERT

@JakubMisek I have only one class with the name ArrayObject but it is in another namespace.

I just updated my version of PHP Tools and I have always the same errors.

JakubMisek

Jean-FrancoisHIVERT, thank you.

This really indicates that there is another class ArrayObject in your workspace, and it is without the correct annotations. This causes the editor to report the error.

You should see the following signature (with parameter type hints) on parent::exchangeArray():

If you have additional stubs and definitions in your workspace, the editor will warn about errors like this, and it will also be slower and consume more RAM.

Jean-FrancoisHIVERT

I found where is this ArrayObject class, it was in a phar file like box.phar, and in a vendor package of the box project.

To avoid that, I added in my settings:

"files.exclude": {
        /**
         * Avoid to index PHP files in PHAR else
         * it could cause issues with intellisense
         */
        "**/*.phar": true
}

FYI, I needed to reload my VSCode to see that it fixed my issue.

Thank you for your help, you can close this ticket, and sorry for the noise.

JakubMisek

Jean-FrancoisHIVERT, good that you found the cause of it.

This was a good question, and I hope it helps others as well.