Latest pre-releases intermittently fail on save actions.

JakubMisek

reio php-cs-fixer won't be the culprit, it runs in a separate process and wouldn't block our code actions.

reio

Like I remembered, 1.74.19252 and earlier 1.74 versions after that fail silently. No message about code actions, memory usage at 400MB, but saving just doesn't react. Getting code actions from PHP started being shown in the last few pre-release versions.

reio

Ok, narrowed it down to a tee now. The last 2 1.73 prereleases are broken too.

1.73.19228 broken
1.73.19214 works

JakubMisek

reio, thank you. There is only one change between them: a code action to promote the constructor property.

We can prepare a pre-release without this feature and see ...

Sadly, we don't have any project that reproduces the issue on our machines.

JakubMisek

reio, we have released pre-release 1.74.19368 that don't have the affected code action.

I still don't think it fixes it, but it's the only difference between those versions :)

reio

JakubMisek No cigar. But removing "editor.codeActionsOnSave": { "source.organizeImports": "explicit" } seemed to help instantly to be able to save. However php.devsense.ls memory keeps climbing and language features stop working now...

JakubMisek

reio, thank you.

Makes sense, removing editor.codeActionsOnSave may avoid touching that deadlocked thread.

1.73.19228 broken

So this version starts consuming memory and eventually language feature stop work either?

reio

JakubMisek Correct.

JakubMisek

reio thank you,

It does not make much sense because 1.73.19228 didn't introduce any changes.

~~So far, we have tried dozens of open-source projects based on Symfony, and we can't reproduce the issue ...~~

~~- I can add internal diagnostics that would log anything taking longer than expected.~~
~~- Or we would really appreciate anyone sharing the project causing the issue - settings and the minimal test case.~~

~~There must be something different on affected machines~~

EDIT: we found the issue - it's caused by some syntactically incorrect .php files, usually a part of unit tests included in some composer packages.

reio

JakubMisek Oof :)

JakubMisek

reio, please feel free to try 1.74.19378 with the fix. It fixes the issue matching the symptoms described in this thread.

Release 1.75 will be out soon!

« Previous Page