Many issues with the pre-release version

Jean-FrancoisHIVERT

Hi,

I found many issues with the last pre-release version:

<?php

declare(strict_types=1);

namespace Devsense\Release\V_20261019;

use Closure;
use stdClass;

$array = [];
$array['a'] = 123;
$array['b'] = 456;

uksort($array, function (string $keyA, string $keyB) {
    return 0;
});

/**
 * @param stdClass[]|stdClass[][] $stores
 */
function test1(array|stdClass ...$stores)
{
    array_walk_recursive($stores, function (stdClass $objectDef) {});
}

/**
 * @param Closure(): void $callback
 */
function test2(Closure $callback) {}

test2(function () {
    echo 'TEST';
});

test2(function (): void {
    echo 'TEST';
});

Thank you for the fixes.

I will continue to check the new errors.

Jean-FrancoisHIVERT

Another issue:

/**
 * @param Countable|iterable<mixed> $haystack
 */
function test3(Countable|iterable $haystack) {}

/**
 * @template TValue of stdClass
 */
class A implements Countable, IteratorAggregate
{
    public function count(): int
    {
        return 0;
    }

    /**
     * @return ArrayIterator<TValue>
     */
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator([]);
    }
}

/**
 * @template TValue of stdClass
 * @implements IteratorAggregate<TValue>
 */
class B implements Countable, IteratorAggregate
{
    public function count(): int
    {
        return 0;
    }

    /**
     * @return ArrayIterator<TValue>
     */
    public function getIterator(): ArrayIterator
    {
        return new ArrayIterator([]);
    }
}

/**
 * @var A<stdClass> $a
 */
$a = new A();

test3($a);

/**
 * @var B<stdClass> $b
 */
$b = new B();

test3($b);

JakubMisek

Thank you @Jean-FrancoisHIVERT ,

[x] incorrect aksort() annotation fixed, causing it to match TValue instead of array-key
[x] @param for variadic arguments does some magic because some frameworks annotate the array type and some the array item type; we fixed it to respect this case.
[x] check for anonymous function return type to respect void
[x] IteratorAggregate<TKey, TValue> was not resolved correctly from IteratorAggregate without specification.
[x] Template argument type check failed for unresolved generic parameter (array-key vs. TKey)

Jean-FrancoisHIVERT

About ArrayIterator<TKey, TValue> was not resolved correctly from ArrayIterator<TValue> you mean it is not an issue but a problem about the PHPDoc?

JakubMisek

Jean-FrancoisHIVERT there were two internal issues

TKey was not specified, but due to a bug it was resolved to a "random" type in the parent's scope.
TKey check against array-key always failed.

Jean-FrancoisHIVERT

thank you