Prevent status bar from changing color if XDebug cannot start

phptools

Hi,

When I start my XDebug, the status bar color changes from blue to orange (at least for the theme I'm using)
However, often, I have multiple instances of VSCode running and one of them might already be listening for XDebug
When running a 2nd instance of the listener, an exception will be thrown, however, the status bar still turns orange, giving me the perception that it is listening
My suggestion is to prevent the status bar from changing color if the Listener failed to start, possible?

Thank you.

JakubMisek

Hi,

Yes, that's how it should be.
We have added a few more checks so the error will be reported in detail, and debugging will be canceled with an error message.

A side note - if you're debugging a console program or starting our built-in server, you can remove the "port" launch setting so PHP Tools will find a free port automatically.

phptools

I take it that in future, status bar will not change color if XDebug fails to start right?

All my debugging are happening from a remote server although I have been exploring how to do development locally. Thanks!

JakubMisek

I see. Yes, debugging (listen for xdebug connection) should fail and VSCode won't change into the debugging mode (the orange bar)

JakubMisek

Hi - we have released an update that should improve the debugging experience.

Please let me know if it works for you.

Thank you!

phptools

I'm on VSCode 1.60.2 using the v1.6.8448 of the extension. It doesn't work, still as before, throws an exception in the console and turns orange

Listening to Xdebug on port  ...

[Error: listen EADDRINUSE: address already in use :::9000
	at Server.setupListenHandle [as _listen2] (net.js:1318:16)
	at listenInCluster (net.js:1366:12)
	at Server.listen (net.js:1452:7)

JakubMisek

Thanks,

It's weird, it should say a little bit something different:

Listening to Xdebug on port **something** ...

We'll take a look on that!

phptools

The full output here

Listening to Xdebug on port  ...

[Error: listen EADDRINUSE: address already in use :::9000
	at Server.setupListenHandle [as _listen2] (net.js:1318:16)
	at listenInCluster (net.js:1366:12)
	at Server.listen (net.js:1452:7)
	at e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:6274
	at new Promise (<anonymous>)
	at f (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:5175)
	at vi.<anonymous> (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:6375)
	at Generator.next (<anonymous>)
	at e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:373
	at new Promise (<anonymous>)
	at e (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:121)
	at e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:6336
	at Array.forEach (<anonymous>)
	at vi.<anonymous> (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:6325)
	at Generator.next (<anonymous>)
	at e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:373
	at new Promise (<anonymous>)
	at e (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:121)
	at vi.launchRequest (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:3053)
	at vi.dispatchRequest (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\node_modules\vscode-debugadapter\lib\debugSession.js:378:22)
	at vi.dispatchRequest (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\out\src\debug\debugger.js:1:9442)
	at vi.handleMessage (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\node_modules\vscode-debugadapter\lib\protocol.js:61:18)
	at vi._handleData (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\node_modules\vscode-debugadapter\lib\protocol.js:155:34)
	at Socket.<anonymous> (e:\portable\vscode\extensions\devsense.phptools-vscode-1.6.8448\node_modules\vscode-debugadapter\lib\protocol.js:80:44)
	at Socket.emit (events.js:315:20)
	at Socket.EventEmitter.emit (domain.js:467:12)
	at addChunk (internal/streams/readable.js:309:12)
	at readableAddChunk (internal/streams/readable.js:284:9)
	at Socket.Readable.push (internal/streams/readable.js:223:10)
	at TCP.onStreamRead (internal/stream_base_commons.js:188:23)] {
  code: 'EADDRINUSE',
  errno: -4091,
  syscall: 'listen',
  address: '::',
  port: 9000

phptools

It does say port 9000 elsewhere in the output.

JakubMisek

I see, thanks. I think we have fixed that. It only happened on linux/mac as I can tell.

phptools

Ok, let me know when it is released? I still see mine as v1.6.8448

JakubMisek

ok, we're still working on other features, so once it's ready, there will be a release

phptools

Wait.. Did I mention I was on win 10? I just saw your mention of linux/mac..

JakubMisek

phptools hm I assumed it's Linux, because we couldn't replicate this issue on Win; Although this should fix the problem in general, Let's see.

phptools

For clarity,

PHP and XDebug runs on Ubuntu
Ubuntu runs in a VirtualBox being hosted by Windows 10
VSCode runs on Windows 10 and listens on port 9000
When I have multiple VSCode instances on Windows 10, all their status bar will change to orange, however, only one actually listens, the others get the exception message shared above

JakubMisek

The latest update v1.7 should behave correctly, please let me know if it works for you.

Thanks

phptools

For whatever reason, I can't seem to get the latest version. Is there compatibility limits with VSCode 1.60.x?

JakubMisek

Maybe, we are ensuring compatibility with vscode ^1.63.1; Is there a reason the vscode can't be updated?

phptools

Yes, that would be the reason.

Is 1.63.1 the real minimum compatibility? :)

Looks like I will have to update my VSCode

JakubMisek

We had to increase the minimum version in order to provide the support for installing the extension in the browser (http://vscode.dev/). Although internally, the extension could still run on 1.51 :)