formatting keep braces in the same line

orestisgounalakis

hi how can i braces in the same line in php tools

JakubMisek

Hello,

There is a setting whether to comply with PSR-2 notation which keeps braces on the same line, except for classes.

{
  "php.format.codeStyle": "PSR-2"
}

This should be enabled by default, Do you have an example code, where it's not working as expected?

Thank you.

More settings can be found at https://docs.devsense.com/en/vscode/configuration#configuration-options

Ray

I can confirm that PSR-2 places the braces on the next line for both classes and functions.

I would be very nice to have a settings php.format.braces and have the options:

k&r (Keep braces on the same line for classes, functions and control structures)
allman (Places braces on next line for classes, functions and control structures)

Reference: https://en.wikipedia.org/wiki/Indentation_style

If we had this feature we could get rid of PHP Intelephense.

Please, please, please :)

Ray

Any chance you could put this one in the next release?

MiloslavBeno

Hi Ray,

Thank you for your post!

Yes, we will try our best to put it there.

Thanks!

MiloslavBeno

Hi Ray!

I'm happy to say this will be in the upcoming pre-release ;-)

Thank you for your suggestion!

Ray

Thank you for bundling this feature in the current release. I am currently testing the pre-release v1.18.10828 and I am not seeing the K&R in the settings. I am not sure how to enable Keeping braces on the same line for classes, functions and control structures.

Formatted

What am I missing?

MiloslavBeno

It will be there in the upcoming pre-release version. Most likely during tomorrow.

Ray

Boom! Thank you. You guys are the best!

MiloslavBeno

Thank you, Ray!

You should be able to test it out right now - the pre-release 1.18.10855 has two more code styles. allman and k&r

Please let us know how it goes ;-)

Ray

The only use case that you are missing is the if/else. The else like should read } else { and not go to a new line.

Other then that I have not found any other issues.

MiloslavBeno

Great! Thank you, Ray, for trying it.

We'll handle this case too!

MiloslavBeno

And it's the same for catch and finally. Will be done.

Ray

I found one more.

This is what I would expect

Instead I get this

Ray

Found another one

Formatted

Notice it moved the fund attribute inline, the added space in the fund string and the new line in the disease attrbiute.

MiloslavBeno

Hi John,

Thank you for reporting those issues. They've all been addressed in the pre-release 1.18.10878 - available now.

If you run into anything else... you know where to find us :-)

Thank you!

Ray

All the class related formatting is perfect! I am loving it!

There is one issue with formatting HTML where its loosing the indents and multiline.

MiloslavBeno

Ray

This one behaves according to the VS Code HTML formatter settings.

You can configure it with html.format.wrapAttributes in settings.json

auto: Wrap when the line length is exceeded
force: Wrap all attributes, except first
force-aligned: Wrap all attributes, except the first, and align attributes
force-expand-multiline: Wrap all attributes
aligned-multiple: Wrap when line length is exceeded, align attributes vertically
preserve: Preserve wrapping of attributes
preserve-aligned: Preserve wrapping of attributes but align

So preserve or preserve-aligned should do the trick.

You can find the list of all settings at https://code.visualstudio.com/docs/languages/html#_formatting

Ray

Here is a nice to have if possible.

MiloslavBeno

Ray Makes sense. I'm adding this to our list! Thank you!

Ray

Found another one.

MiloslavBeno

Ray will be done