Manual indexing (or automatic after vendor folder changes)

d8vjork

Don't know if this is a real issue or not at all (if not then trait it as a feature proposal).

When I cloned a new PHP project locally then open it in VS Code and install its dependencies with composer, it didn't re-index automatically which leads me to reload the whole VS Code window (or reopen)

This could be a nice feature to add in terms of user experience

JakubMisek

Oh we should already automatically reindex, so this might be a bug actually (regression)

thank you!

d8vjork

Oh! Btw I think it happens when I switched to the pre-release version, so probably isn't in the stable branch

JakubMisek

thanks! Is it happening in a local or remote workspace?

The extension is watching directory changes, although it may break on various Linux distributions.

d8vjork

JakubMisek In a local one, I'm using Mac OS X if that helps

JakubMisek

So this is actually an issue we're tracking for some time already
https://github.com/DEVSENSE/phptools-docs/issues/165

We're still working on it. AFAIK It's happening to most others VSC extensions since it is caused by the underlying implementation of file system watchers.

Manual "re-index" would just workaround the issue itself, anyways, I hope we get this fixed soon.

d8vjork

JakubMisek Cool. Hope this problem gets solved then!

If you need a reference, PHP intelephense one seems to have this working

JakubMisek

d8vjork thanks 🙂

We're looking at other extension issues as well, and we're happy that we have most of them solved or not happening at all. Anyways according to the issues, this one is a problem for intellephense too. Anyways, we're working on it.

JakubMisek

we have prepared pre-release that should fix that! please feel free to try. We'll keep working on it.

JakubMisek

@d8vjork is it still happening? We have changed a few related issues since 1.22.

Thanks!

d8vjork

JakubMisek Awesome! I'll try later as today my work was mostly on "boring" frontend stuff on my company.

d8vjork

JakubMisek Ok I had an opportunity to test this in a new project I'm working on and still happening:

Notice Laravel introduced this new classes for mails which came from the composer update I did run, but LSP still didn't recognise the changes nor refresh the view (warnings didn't get a noticeable blinking)

JakubMisek

damn, thank you, is it Linux/Mac? We have it fixed at least on Windows, but it seems it's not perfect.

d8vjork

JakubMisek It's happening on Mac OS 12.6.1 atm

d8vjork

JakubMisek Managed to replicate the same now using version 1.26.11776, seems sometimes its fine but probably not with adding new stuff to the vendor folder (running composer require)

JakubMisek

d8vjork the language server watches the workspace folder (including vendor) for any filesystem changes, waits a few seconds after all the file system changes are finished, and analyzes the modified files ... although, on Unix systems, sometimes, we're not getting all the filesystem events I guess?

We are testing this on Linux and Mac, and we couldn't replicate those issues, so there must be something else happening. Maybe we should add more details logs to find out

d8vjork

JakubMisek happy to help out if there is more details in the logs, can try as I'm always playing with my own / others composer packages in many different projects (light to heavy)

JakubMisek

d8vjork awesome, thank you very much for your help @d8vjork - we'll put something together

JakubMisek

d8vjork pre-release 1.28.12202 is out!

indexing fixed after composer updates and other file system events
there are additional indexing logs in Output / PHP Language Server