Problem with func_get_args() and PHPDoc

CSoellinger

Not really sure if this is a bug or better should be a feature request, however i have a small Problem with the community edition if there is a func_get_args() to get all arguments (honestly, i don't like this method, but the SilverStripe PHP framework is using this 🙄). But, they are using PHPDocs ;)

So now if i hove the function it tells me two things at my usage:

First, i am using too many arguments
Second, it does not show the arguments from phpdoc (maybe cause of the union types? 🤔)

At least i want to say, thanks for the good work, i'm already happy with the community edition :)

greetz
Christopher

JakubMisek

thank you for reporting this issue! we have just fixed it, and it is already available in the latest pre-release

CSoellinger

JakubMisek Nice to hear, thanks at all :)

CSoellinger

JakubMisek Hi, changelog told me that this problem should be gone till the last update but i still get errors at silverstripe projects (did not make other tryouts..)

Simple steps to reproduce:

Run "composer create-project silverstripe/installer my-project"
Open created directory with vs code "code ./my-project/"
Open PageController file inside "./app/src/"
Add the following line at line number 31: $page = Page::get()->filter(['ID' => [1, 2]]);

You will see a problem report for too many arguments..

I did not try the pre release, will do that later, maybe there is a bugfix which is not already in stable :/

My solution for now is turning this rule off by the .editorconfig file, but that's not really what i want ;)

greetings
Chris

JakubMisek

thank you @CSoellinger for the update! we'll try that

JakubMisek

Fixed, and preparing pre-release.

The next release will handle it properly :) thank you!

CSoellinger

Oh yeah, works perfect :) thanks at all :)

JakubMisek

CSoellinger awesome, thank you for the update!