Imagick stub not recognized

CSoellinger

Hi,

I have the problem that i can't add the imagick stub without setting "php.stubs" to "all". I also tried to set the php path directly (i'm using multiple php versions on my laptop) but the problem still exists.

I have two screenshots, first where you see the code and my settings for php tools. Second shows the cli output for "php -m | grep imagick" so you can see the php modules are definitely installed :)

For now i'm using the "all" setting, don't see much performance downsides (for now!!) with it, so it's ok for me. I think i also could only include the imagick stub from somewhere (or maybe i misunderstood the "php.stubs" config and i have to include the stub by myself :) )

I'm pretty sure this is more a configuration problem than a bug from php tools ;)

cheers
Christopher

JakubMisek

thank you for reporting that! we'll take a look

JakubMisek

the following setting works for us:

"php.stubs": ["*", "imagick"],

Maybe you have the setting "overriden" in a local .vscode/settings.json file?

CSoellinger

JakubMisek

Ok, i have tried to create a simple file called test.php where i've added the following lines

<?php
$img = new Imagick();
$unknownClass = new Unknown();

First: I do not get an error for "new Unknown()" what is a bit strange cause i created only one php file inside an empty directory there is really no class called "Unknown". I do not have a composer file or vendor dir nor a .vscode directory. For my opinion this is the simplest case i could have..
If make a syntax error it also shows at problems inside vscode. And of course, the directory where i have created the test.php file is trusted by vscode.

However, second thing, i do not get an error for the Imagick class, but if i hover it with the mouse i only see the stub informations if i use the following config

"php.stubs": ["all"],

I have tried your setting with my simple PHP file and i do not see any doc informations for imagick again :/

I also tried to deactivate all vscode plugins except PHP Tools, did not help..

Soo, can also you test a simple PHP file inside an emtpy directory (but which is trusted by vscode) and write in the PHP code from above? Cause if you do not have problems with your "php.stubs" config maybe it's a linux specific problem oO (no idea for now what this could be).

At least i will try the same on another client in the evening... debugging at it's best ;)

JakubMisek

thank you for testing it! We'll try again. Maybe the german language pack may cause something since we're also localizing the manual according to the vscode locale.

CSoellinger

Ok, no idea if you did something at the last update but it's working now... mostly... ;D
If i use the config like said above i now don't get an unknown class error.

But if i open only a file with VSCode (not a workspace, not a directory, just open vscode and open a php file which is NOT inside a directory which has a .vscode or similar), i still get no PHP error messages also for the unknown class.. But if i open the same file inside an open workspace i'll get the PHP errors. Hope you know what i mean, i could also provide you a small screen recording where i exactly can show you my steps.

But for me it's easy to reproduce. Create a PHP File inside an empty directory. Write the code from above inside it and open the file both ways like i described.

However, this are mostly errors which don't block me at coding, but it really interests me why this happens :/

cheers

JakubMisek

thank you for the update!

This makes sense;

single file, no workspace: we don't report "unknown symbol" errors
if the file is opened within a workspace: "unknown symbol" is reported; then the .vscode settings should be applied

you can put the following setting into the global VSCode settings (File -> Preferences -> Settings).

"php.stubs": ["*", "imagick"],

JakubMisek

We have fixed "php.stubs" setting in the recent release - it was causing the issue with undefined functions and classes from specified extensions.