Unreachable code detected with instanceof test

Jean-FrancoisHIVERT

The fix #765 causes another bug PHP0419 with instanceof test:

public function group(array $addresses)
{
        $status = true;
        $this->resetAddresses();

        foreach($addresses as $addressApi)
        {
                if($addressApi instanceof Address) {
                        $this->_datas['addresses'][] = $addressApi;
                }
                else {
                        $status = false;
                }
        }

        $this->refresh();
        return $status;
}

Thank you for the fix.

JakubMisek

thanks;

Here, since $addresses is Address[], the code seems unreachable; but we should not be that strict in this case I guess

Jean-FrancoisHIVERT

You are right @JakubMisek but as PHP does not allow to define array items type, the PHP type is array so we need a instanceof test.

JakubMisek

We won't resolve the value of instanceof expression (true/false) in the upcoming pre-release; That was too strict.