Bug in new get/set/@property checks

Jean-FrancoisHIVERT

Hi,

With the last 1.30 version v1.30.12417 which implements Reports use of undefined property if there is __get/__set but also @property doc comment declaration., my errors increases of 900 (50 to 950 errors).

Anyway, I found an issue because I have the @property documentation and F12 works as well but PHPTools returns an error Undefined property due to the parent class.

FYI: Api\AbstractApi > API\Rule\AbstractRule >API\Rule\ACL

Thank you for the fix.

JakubMisek

Jean-FrancoisHIVERT what's the type of $ruleApi_a?

JakubMisek

Thank you. We have been improving the analysis of the case described in the following post
https://community.devsense.com/d/614-support-for-phpstan/22

However, it should never report Undefined property when the @property is defined. Let me look into it.

Jean-FrancoisHIVERT

$ruleApi_a is of type AbstractApi|Rule.

<?php
	namespace PhpCliShell\Application\Firewall\Core\Api;

	use PhpCliShell\Application\Firewall\Core\Api\Rule\Acl;

	final class Rule extends Acl
	{
		/**
		 * @todo Deprecated, use ACL class instead of this class
		 */
	}

Api\AbstractApi > API\Rule\AbstractRule >API\Rule\ACL > API\Rule

I work on the migration from API\Rule to API\Rule\ACL so the code is in API\Rule\ACL

JakubMisek

I've found a small test case:

Working on it!