High CPU usage of `rg` process when symlinks are used

BorekBernard

Hi, our monorepo which is a combination of PHP and JS projects uses the pnpm package manager for JS projects, and pnpm creates a lot of symlinks.

When we have PHP Tools enabled for this repo, CPU usage of the rg processes (ripgrep) skyrockets and never finishes.

Without PHP Tools, everything is fine.

The workaround is to set "search.followSymlinks": false in settings.json.

JakubMisek

BorekBernard thank you, Borek, for reporting the issue!

We have actually removed most of the search processes within PHP Tools, but there are probably some left - we'll look into it.

JakubMisek

BorekBernard any chance to see the actual commandline arguments of those processes? This would help us to find out what's causing it.

Thank you!

BorekBernard

JakubMisek Sorry, notifications are not enabled by default so I missed your question.

The output of ps -p <PID> -ww -o command is this:

/Applications/Visual Studio Code.app/Contents/Resources/app/node_modules.asar.unpacked/@vscode/ripgrep/bin/rg --files --hidden --case-sensitive -g /web/core/lib/Drupal.php -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/Thumbs.db --no-ignore --follow --no-config --no-ignore-global

JakubMisek

BorekBernard thank you! fixed, and preparing pre-release

BorekBernard

JakubMisek Wow that was fast, thank you!

JakubMisek

BorekBernard thank you too!

If there'd be any other rg processes, please let us know.

BorekBernard

I'm trying the new version (v1.31.12821) and still seeing the issue – this is the output of ps -p... this time:

/Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Plugin).app/Contents/MacOS/Code Helper (Plugin) --type=utility --utility-sub-type=node.mojom.NodeService --lang=en-US --service-sandbox-type=none --inspect-port=0 --user-data-dir=/Users/borekb/Library/Application Support/Code --standard-schemes=vscode-webview,vscode-file --secure-schemes=vscode-webview,vscode-file --bypasscsp-schemes --cors-schemes=vscode-webview,vscode-file --fetch-schemes=vscode-webview,vscode-file --service-worker-schemes=vscode-webview --streaming-schemes --shared-files --field-trial-handle=1718379636,r,363196742449149930,722894780692322390,131072 --disable-features=CalculateNativeWinOcclusion,SpareRendererForSitePerProcess

Not sure if still related to this extension...

JakubMisek

BorekBernard thank you; it's hard to tell. Some say it's CoPilot (https://github.com/microsoft/vscode/issues/148226#issuecomment-1421203087)

JakubMisek

I'll mark this issue as "solved", and please feel free to report anything else that we should fix :)

thanks!