Strange spaces appearing

VladislavKosev

Merry Christmas to everyone on Devsense team!!

There are strange spaces appearing in my code since the last version (I think, haven't noticed them before). I have tabs setup for all my PHP files, but it seems that once there are spaces, they don't go away (previously they were overwritten when increasing or decreasing indent on that line).

Currently somehow the comment on top of the class causes the spaces to be produced ALWAYS between the opening and closing braces of a class (at least, haven't checked thoroughly). That comment is the one in the default class template. If I remove it, the problem seems to go away.

This seems like enough information for now. If you need more info or tests, please do ask :-)

JakubMisek

Merry Christmas :)

Can you post us the code and point us where are the spaces?
Do you have indentation set to smart instead of block ?

VladislavKosev

Check out the screenshots I have attached. I tested both smart and block. Same stuff.

JakubMisek

And what spaces do you mean? I don't see anything unusual on the screenshot.

VladislavKosev

JakubMisek
Before "function", line 16, despite lines 17 and 18 being tabs. It keeps inserting spaces until you remove the comment.

JakubMisek

Do you have .editorconfig file or tabs set in Tools / Options / Text Editor / PHP ?

VladislavKosev

JakubMisek No. Remove the comment and it works. In my mind clearly the comment has something to do here. Bring back the comment and it breaks again. In the bottom right, where there's an option for changing the tabs and spaces (looks like this: Ln: 51 Ch: 2 TABS CRLF), says MIXED then the comment is there (even if there are no spaces anywhere) and TABS when there is no comment.

JakubMisek

But Visual Studio only cares about Tools / Options / Text Editor / PHP options. If the tabs are mixed it "might" try to detect the tab/spaces settings from the source code (but it differs on the operation, and version of VS).

VladislavKosev

Dude, the spaces in front of __construct were created after I pressed Tab. Are you saying that this is a VS bug? Can you try and duplicate? Just take this code without the constructor. a) see what the bottom right says and b) try to press tab inside the class.

JakubMisek

If it is caused by pressing tab, it is handled by Visual Studio Editor, and behaves according to your setting in Tools/Options/Text Editor :)

Edit: sometimes Visual Studio scans the source file for the first occurrence of a whitespace character, and uses it

VladislavKosev

JakubMisek Can you verify you have the same bug then?

VladislavKosev

I've found it. It's the new "Use adaptive formatting option" in Visual Studio. Doesn't change what it says in the lower right, but it does change what gets inserted when there are no indents. It is confused by the spaces in the multiline comment, I think (even if there are no indents with 1 space).

JakubMisek

That makes sense, thank you for finding out. I guess the option can be turned off?

VladislavKosev

Yes, but then editing yaml files suck, because I get tabs instead of spaces :-) I can live with that.

JakubMisek

I see. Isn't there a support for YAML language? where you could set Spaces instead of Tabs ?

VladislavKosev

JakubMisek Don't think so. Didn't find anything in the store.