High resources

phptools

In case you wonder why the 2nd vendor is exists, that is because the package B looks inside its child folders for the packages it needs, it will not look towards its parent(s)

JakubMisek

phptools I see! right, it doesn't make sense to scan the nested vendor folder then.

JakubMisek

phptools For that purpose, I thought the composer had an API providing the list of installed packages, their paths, and package dependencies.

JakubMisek

pre-release 1.37.13695 ignores the nested /vendor/, please let me know how it works for you)

JakubMisek

Version 1.38 avoids allocating and indexing /vendor/ folder if not necessary. There is a new caching mechanism and several improvements.

Please update and let us know how it works.

Thanks!

phptools

JakubMisek

My v1.39.13943 language server is taking very long to do its job again. Any idea?

phptools

it is taking over 5 minutes...

JakubMisek

phptools It should not be more than a few seconds.

Please try the pre-release 1.39.13983 which handles symlinks in /vendor/ folder - it seems like it's your case.

phptools

Not sure what I did, but it seems better now. Here's what happened:

It was slow, I did a reboot, still slow, so I sent the screenshot above

I did add this

    "files.exclude": {
    "inherit": true,
    "**/vendor/**/vendor/**": true // had no effect whether enabled or not
},
//excludes fies & folders for watcher service
"files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true,
    "**/env/**": true,
    "**/venv/**": true
},
"search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/env": true,
    "**/venv": true
},

phptools

JakubMisek

Go to Definition breaks when I add this, feels like a bug to me

    "files.exclude": {   
        "**/vendor/**/vendor/**": true
    },

Is there a way to make the extension stay on a certain version so that I can stay in a known state? Perhaps using a configuration setting?

JakubMisek

phptools

1/ Go To Definition will ignore definitions in the /vendor/**/vendor workspace folders in this case.

2/ You can always choose a specific version in VSCode / Extensions panel /

phptools

Hi, this remains to be a problem to the extent that I have to constantly find and delete my nested vendor folders.

Language server must SCAN: vendor/**
Language server must NOT SCAN: vendor/**/vendor

Possible to configure the above?

JakubMisek

phptools thank you for reminding me.

Currently, we index everything in /vendor/**; I'm aware it's incorrect, and we're working on it.

I think we should (by default) ignore vendor/**/vendor/ (unless you explicitly open that file in the editor)

phptools

this would be a perfect xmas present :)

phptools

I'm thinking, the logic can be simplified to

If PHPTools finds vendor folders that are exactly 2 segments apart, then skip it e.g. **/vendor/1/2/vendor

It should work because this is the way nested vendor by composer would look like.
Also, there are some packages out there that chose to name some of their folders as vendor 🤦‍♂🤦‍♂🤦‍♂
Hide this behind a checkbox (Experimental) Skip nested vendor folders. If it solves the problem, then we can work on something more "proper"

JakubMisek

@phptools finally after long time

files.exclude and search.exclude patterns will behave as expected

The next update will respect both settings and should behave correctly. ( https://github.com/DEVSENSE/phptools-docs/issues/780#issuecomment-2781399853 )

If there will be inconsistencies, please report :)

phptools

unfortunately, CPU remains super high, 1000%, always the language server

phptools

All replies are now hidden automatically until "approved"... why?
It has been years... when can this high cpu load be properly resolved?

JakubMisek

phptools The problem is that we can't replicate any of these issues on any of our test machines.

Currently, we will ignore vendor/**/vendor/ files; however, this is likely not related to the high CPU usage.

If we could get any steps to reproduce the issue, we're keen to fix it.

JakubMisek

phptools

All replies are now hidden automatically until "approved"... why?

It's a spam prevention. In this case, we haven't noticed because the thread is marked as solved, sorry for that. If there is anything new, please create a new Discussion.

« Previous Page