Last release replaces indent spaces with tabs

Murz

After updating to the last release (v1.42.14626) I got a problem with replacing indent spaces with tabs, even if in VS Code it's configured to use spaces.

Workaround with "Save without formatting" works well, but the regular save - always does the damage.

Disabling the PHP extension resolves this problem. Please fix this.

JakubMisek

Murz Thank you for reporting that.

Just to be sure - isn't there .editorconfig file with insertSpaces directive?

JakubMisek

Murz The insertSpaces behavior depends on the following in the following order:

setting "php.format.codeStyle"
.editorconfig file
setting "editor.insertSpaces"

Murz

I have:

php.format.codeStyle: Drupal
no .editorconfig
editor.insertSpaces: checked.

Reverting to the previous release (v1.43.14741) resolves the problem, updating to the last (v1.42.14626) brings it back.

JakubMisek

Murz It seems we defined "drupal" code style to force tabs. (I think PHP Storm sets tabs for Drupal as well)

I assume it's not correct?

We'll update Drupal code style, AND
we'll prioritize user's setting of editor.insertSpaces if set.

Murz

JakubMisek It seems we defined "drupal" code style to force tabs. (I think PHP Storm sets tabs for Drupal as well)

I assume it's not correct?

Yes, the Drupal code style uses spaces only: https://www.drupal.org/docs/develop/standards/php/php-coding-standards#indenting
So pls fix this.

JakubMisek

Murz thanks, our bad.

Releasing update in a few minutes.