Help with 0406 / 0423 codes

Alystair

An open source 3rd party data validation library (Respect\Validation) is giving me 0423 errors and I'm wondering what I need to submit in a PR to fix them?

The missing argument 0423 error is traced back to this PHPDOC block line:
* @method static Validator alnum(string ...$additionalChars)

Additionally getting some expected type 0406 errors but it must be more tricky to fix?
Argument '1' passed to optional() is expected to be of type Validatable, Respect\Validation\Validator given
Relevant PHPDOC block:
* @method static Validator optional(Validatable $rule)

JakubMisek

Thank you for reporting this.

PHP0423 seems to be an issue in PHP Tools, where the vararg (...) signature is incorrectly processed:

Will be fixed within the next update.

PHP0406 is caused because of the namespace was not specified, PHPDoc should be:

* @method static Validator optional(\Respect\Validation\Validatable $rule)

or use statement at the top of the script:

use Respect\Validation\Validatable;

Alystair

unsure if I need to ping JakubMisek - but this is in 'solved' group... sorry if I didn't have to!

Alystair

Thanks!

Alystair

Hi Jakub - I still believe the 406 error is from your end. The remote file https://github.com/Respect/Validation/blob/master/library/Validator.php
Is within the correct Respect\Validation namespace, and the method in question is already * @method static Validator optional(Validatable $rule).

Perhaps it's because in our local context it's used as use \Respect\Validation\Validator as v;? Adding use \Respect\Validation\Validatable; to local context gives a 7001 'use directive is unnecessary' error and does not solve issue.

Alystair

Yeah, if I replace internal v:: calls ... with \Respect\Validation\Validatable:: the errors go away. 406 error is incorrectly displayed for use x as y; directive when called within themselves.

Eg. v::url()->anyOf(v::startsWith('http://'),v::startsWith('https://'))

JakubMisek

I'm still struggling to find an example of the issue. May I ask for a sample? Is it following?

This is happening to me with or without use

EDIT: seems PHPDoc methods do not respect current namespace and aliases, fixing

JakubMisek

@Alystair this has been fixed and update released. If there is another case of this issue, feel free to let me know

Alystair

Yep, no more 0406 or 0423 errors - feel free to retag as 'solved' :D

JakubMisek

thank you! :)