Wrong case sensitive order of imports sort with organizeImports feature

Murz

I have enabled the source.organizeImports option and it sorts the imports.
But the sort order is wrong with case-sensitivity, so phpcs for Drupal produces an error:

FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Tests\UnitTestCase.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)

The correct order is:

use Drupal\Tests\UnitTestCase;
use Drupal\test_helpers\TestHelpers;
use Drupal\test_helpers\utils\AssertSequence;

But the extension puts the upper case letter at the end of the list:

use Drupal\test_helpers\TestHelpers;
use Drupal\test_helpers\utils\AssertSequence;
use Drupal\Tests\UnitTestCase;

Could you please fix this issue? Or provide an option to configure this behavior? Thanks!

JakubMisek

Murz It looks more like a bug in phpcs, because the names should be case-insensitive.

Murz

It's not a bug, it's intended order checking, here is the rule:
https://github.com/slevomat/coding-standard/blob/8.15.0/SlevomatCodingStandard/Sniffs/Namespaces/AlphabeticallySortedUsesSniff.php
So, it expects class names with uppercase letters to be higher than those with lowercase letters, but the extension puts them below.

JakubMisek

Murz Did you enable case sensitive sorting? Because the default seems to be case-insensitive.

(https://github.com/slevomat/coding-standard/blob/c72b104f89c6d7bd8b739449f9f592cda2e5072b/build/phpcs.xml#L392)

Murz

JakubMisek I just use Drupal CMS code style with default settings, and from the latest Drupal release the phpcs started to produce such errors.

And yes, Drupal Community enforced the case-sensitive sorting of uses in the release 8.3.25 - see the changelog https://www.drupal.org/project/coder/releases/8.3.25

More details are in the issue https://www.drupal.org/project/coder/issues/3470716

kp77

I found this thread because I also have the same issue, also with a Drupal project (but I'm not using vscode). I think the reason is the new release of drupal/coder (8.3.25). This is the commit that switches to case sensitive: https://github.com/pfrenssen/coder/commit/4288ec74b97c0fe339acc13f8e6959b0f6ce614d
With previous version of coder no issues for me.

JakubMisek

kp77 Alright! that makes sense.

So basically we need to either respect that setting or at least to have our own setting.