PHP0402 in recursive anonymous functions

MarcHenderkes

$fixArrayFn = function ($array) use (&$fixArrayFn) {
    $fixArrayFn($array); // <- here
};

This produces:
PHP0402 Illegal function name of type 'void', name must be of type string, array or callable tesla C:\tesla\pc-college\src\Controller\DataTableController.php 268

and

PHP0412 Use of unassigned variable 'fixArrayFn' tesla C:\tesla\pc-college\src\Controller\DataTableController.php 268

And a question: since php doesn't really have type-casting for class objects (...wow), using the workaround of using a function and specifying the return type there causes a PHP0408 of mismatching return type.

public function getOffice() : OtherClass
    {
        return $this;
    }

Can this be done without throwing a warning?

JakubMisek

Thanks for the code sample, the fix for lambdas will be available within the next update.

JakubMisek

Add the

public function getOffice() : OtherClass { return $this; }

I guess OtherClass extends from self. In such case the cast may be dangerous.
You can tell the editor you know what you do ( :) ) by specifying explicitly the type of $this in several ways:

1/ runtime check

public function getOffice() : OtherClass {
	if ($this instanceof OtherClass) {
		return $this;
	}
	throw new LogicException;
}

2/ PHPDoc annotation

public function getOffice() : OtherClass {
	/** @var $this OtherClass */
	return $this;
}

MarcHenderkes

Using the annotation works, thank you.

Still hoping php gets a real typesystem (and a massive STL rework) at some point either way. array_filter($array, $callable) and array_map($callable, $array) are inconsistent and why on earth are those not member methods of traversable anyway haha.

JakubMisek

MarcHenderkes I guess PHP was never designed for writing an object oriented applications, so there we are :)