Duplicate class properties are not marked as an error

Having this PHP class:

<?php declare(strict_types = 1);

class Foo
{
    public int $i;
    public int $i;
}

When (accidentally) declaring the same property multiple times, PHP Tools does not underline the second $i as being a duplicate (PHPStan does).

In contrast:

<?php declare(strict_types = 1);

class Foo
{
    public function f() : void {}
    public function f() : void {}
}

Above, PHP Tools correctly does detect the second declaration of f as an error. (PHPStan does, too).

Could you please also detect and indicate duplicate/multiple properties with the same name as error/warning?

Also, duplicate constants are not detected either:

<?php declare(strict_types = 1);

class Foo
{
    public const A = 1;
    public const A = 2;
}

In above code, PHP Tools does not detect the second A as being an error (PHPStan does):

Cannot redeclare constant Foo::A.

I would love if PHP Tools would also detect this error, too.

thank you, right, we do that for functions (and for constants and properties as well - we just didn't report it)

will be fixed!

fixed! will be available in the next pre-release

Awesome as always. Thanks again, Jakub 🙂

thank you too, we'll be looking into the rest of the issues, subsequently :)

Is it OK if I keep posting things that I find with PHPStan that PHP Tools currently does not detect?

Or is it too noisy for you?

UweKeim sure, please, keep posting :) we're happy for real feedback so we can implement things actually being used