Find All References works wrong

EugeneT

Hi guys,

I just installed the extension on a fresh instance of vscode.

"Find All References" finds methods outside of the project and even private members of the class.

See screenshots.

Is it a feature? :)

EugeneT

Tried different ext versions from v1.22.11089 down to v1.15.10535, PHP 8.1.12 and 8.0.14.

JakubMisek

Hi,

You're right - PHP Tools are a bit more optimistic. It always finds everything that looks possible. We'll tweak it a little ... :)

cannibalmtll

Hello.

Extension version v1.28.12200

In Laravel projects 'Find all references' also has an odd behavior. Besides actual references it also shows string with same name in route files.

Things get even worse when you'll try to rename function (F2). Because it will rename string in route file(wep.php).

JakubMisek

cannibalmtll fixing in the next pre-release/release!

Kristoffer

We are still having issues with "Find all references" in 1.29.12304.

When using "Find on references" on a class-method the "References" list show method-calls on other objects with the same method-name. This is even when the classes are in different namespaces.

When hovering over the method on the editor VSCode recognizes the correct classname.

JakubMisek

Kristoffer thank you for reminding me;

It should not happen when the type $module can be inferred - I'll check what's going on )

JakubMisek

Kristoffer we can't replicate the issue. The "find all references" command takes the type into account, so there might be something else unexpected happening?

Kristoffer

There might be something wrong with our settings.
If i put an error in some file, by calling a random not-existing function the error shows up in the problems panel.
However, when i close the file the error disappears.

Any idea what settings might be worth looking into?

This is our settings.json:

{
"files.exclude": {
"/node_modules": true,
},
"files.watcherExclude": {
"/.git/objects/": true,
"/.git/subtree-cache/": true,
"/node_modules//": true,
},
"php.version": "8.2.1",
"php.problems.exclude" : {
"/shared/vendor/**" : true,
"/": [410]
},
"php.stubs": [
"",
"imagick",
"gmp"
],
"editor.codeLens": false
}

Kristoffer

I figured it out: The setting "php.problems.scope" was set to "opened" (by default).
Changed it to "user" and both the probems-panel and "find all references" started working as expected.

JakubMisek

Kristoffer yes, thanks for finding it out so quick!

kburton-dev

I still have this problem:

Find All References

It shows method-calls on other objects with the same method-name. This is even when the classes are in different namespaces.

I tried to set up a small example in a new codebase but it worked. So basically I can only demonstrate this in our huge work codebase.

JakubMisek

kburton-dev thank you for reminding us.

I'll try to replicate the issue.

recherchedev

Hi, Still have the 'Find all references' issue that searche a function on other classes. Any solution ? thank you.

JakubMisek

recherchedev Thank you for pointing this out,

Do you have a more specific example? This feature depends on how well the editor resolves the type of class.