Hi Kris,

Thank you for providing us with more cases. We're going to take a look at each of those and get back to you.

Arturust seems to be a bot, removed.

    Hi Kris,

    The issue with control flow statements in one line has been fixed. It will be available in the pre-release.

    Thank you!

    Hi Kris,

    Thank you again for your continuous feedback. In the upcoming preview, there will be a fix for the original issue of this thread.

    It's actually caused by a weird behavior of VSC HTML formatter which we use. One "ultimate fix" of these html/php formatting issues would be to use our HTML formatter, which we actually have. But it would behave differently than VSC HTML formatter. And we really like to be as compatible as possible.

    We will see how it goes after this fix :-)

    Cheers!

      Interesting. I wouldn't be averse to using a different HTML formatter, so long as it doesn't behave like the "Format HTML in PHP" extension, which basically re-saves a document after you save it and interferes with undo, etc. I assume if you have an HTML formatter extension, it integrates nicely with your PHP formatting? What do I need to do?

        (Unrelated: do you have a Discord or a Slack or something? Forums are fine, but not the most useful for small back and forths)

          Thanks for your input!

          I meant we have HTML formatter as a component we used in a different project. But it's not released in any VSC extension, we will see if we'll use it in the future.

          We do not have slack or discord... or at least not yet :-)

            22 days later

            • DDP24

              • Post #11
              • Edited

              I have the same problem with the following line, even in the preview version.

              <a class="btn btn-outline-cms-gray" href="index.php?page=communication-systems-edit&submenu=<?php echo $_GET['submenu']; ?>&communicationID=<?php echo $communication['method_id'];
										   echo (isset($langlink) and $langlink) ? '&'.$langlink : NULL;
										   echo (isset($admin_site) and $admin_site) ? '&'.$admin_site : NULL; ?>" role="button" <?php echo (!site_rights(__FILE__, 'edit')) ? ' hidden' : NULL; ?>><i class="fas fa-pencil-alt"></i></a>

              • DDP24

                • Post #12
                • Edited

                DP24 If I remove the i-tag, it continues, as if it doesn't properly understand the tag and resolves it.

                Sometimes the <i class="fas fa-pencil-alt"></i> becomes < i class="fas fa-pencil-alt"></i>

                    DP24 Is this line giving you Change is not allowed. ? Could you please specify what the issue is? (this thread had multiple issues in one).

                        DP24 We found a bug surfacing when formatting the snippet you've provided. Fix will be present in the upcoming pre-release. Thank you!

                            This one should be fixed in the latest pre-release. Closing

                            Thank you! Please feel free to open a new one if you run into anything else.

                            Write a Reply...