"php.problems.exclude" should be case sensitive or enforce relative paths

maxgalbu

I have two folders, one called "vendor" (in which composer installs deps) and another called "Vendor" in which i'd like to have "problems" checked.

But, both these examples exclude the Vendor folder too:

{
    "php.problems.exclude": {
        "vendor": true,
    },
}

{
    "php.problems.exclude": {
        "/vendor": true,
    },
}

JakubMisek

maxgalbu thank you for your feedback!

You're right. We ignore casing for now because some users do.

Anyways; it'd be a good idea to make it consistent with other Visual Studio Code settings - we'll try to fix that.

For now, as a workaround, you can use a more specific pattern, i.e. "src/Vendor": true.

rabol

Small question;

i have this

"php.problems.exclude": {
        "/vendor": true,
        "src/vendor": true
    }

but the problems panes still reports issues e.g ide_helper in vendor/laravel_idea

I would not expect that, or did I miss something ?

JakubMisek

rabol It should look like this:

There is a small delay tho.

Jean-FrancoisHIVERT

I got same issue with a folder at the root that I wanted to ignore and another with same name that I didn't.

Relative path is a good idea, and maybe implement path wildcard like **/vendor.

JakubMisek

Jean-FrancoisHIVERT we should support wildcards already. Additionally, when specifying a folder without a wildcard (i.e. "vendor", it is treated as to "**/vendor/**".

Relative paths like "/vendor" are probably handled incorrectly - I'll check it.

Jean-FrancoisHIVERT

@JakubMisek Just tested this config:

    "files.exclude": {
        "tools": true,
        "src/**/tools": false,
    },

All tools folders are ignored

JakubMisek

Jean-FrancoisHIVERT thanks for the example - I'll try to make it working in the next update.

JakubMisek

still working on some related issues ...