Deleted function ignored

JakubMisek

pmo, thank you;

I don't have unreachable code warning in this code sample - maybe there is some context missing?
isn't there "problems.exclude" setting in your settings.json? this almost looks like diagnostics are turned off for this file

pmo

I only have "php.problems.excludeGitIgnore": true nothing else anywhere.

I figured out the unreachable code, my mistake (one more throw exception above, which was not in a condition) ... still looking for the missing function errors to hit me :)

JakubMisek

pmo I guess the file isn't specified in .gitignore?

pmo

OK since I started this thread I fixed lots of code after previous dev, mostly thanks to enabling the code analysis in the whole workspace. I fixed most of issues OR added them to ignores.

What I still don't have fixed is the original question - shouldn't non-existing function in a class trigger a warning/error when used in the same class or anywhere else? As you can see in the previously attached screenshot, the function is not in the class, yet $this->functionName is not underlined or anything. As it doesn't exist, the modal box won't show and that's only way to figure out something is wrong.
Is this a feature or a bug? Is the only option to detect these to run PHPStan or similar tool?

JakubMisek

pmo Thank you for the update.

If the error is not underlined, the file may be excluded from code analysis.

please check the file does not have something like // @phpcs:ignore
in the VSCode's settings.json, there is no "php.problems.exclude": ... setting
quick "smoke test": if you write something like strlen(); Does it underline it with a "missing argument" warning? (to see if diagnostics are enabled for this file)

pmo

there are no @phpcs:ignore rules
I do have php.problems.exclude .. but only recently added for unreachable code..
strlen() is underlined, I also see the "problem" in list, Missing argument $string for strlen(), PHP0423
Errors are correctly underlined for core PHP functions and even functions from external classes, but not when I reference function from the same class using $this. Strangely, self:: seems to work fine

JakubMisek

pmo Thank you for the details. I'll try to replicate the issue on my machine.

JakubMisek

pmo note - we don't report unknown methods on $this in trait or if parent class is unknown.

pmo

Well, that s***s a bit :) my class extends Model (Laravel), so because of that, $this is ignored even if the method used in same class and file is not found. It is what it is, but for me this doesn't sound right. Such error shouldn't be ignored if it comes from the same class. I'll try to find a different way to check these errors before I commit..

JakubMisek

pmo only in trait - because you never know who is using that trait.

pmo

yes that makes sense, but here in this specific scenario, I have a file Invoice.php in app folder, which only has Invoice class in it, which extends Model. It's not trait and it doesn't underline non-existent function when referencing via $this and I don't get why. Model uses trait ForwardsCalls and that's it. Does that mean, that when I extend a Model in Laravel, it will break highlighting of such errors in my code, because parent class uses a trait? As I mentioned before, this works fine in PHPStorm ..

JakubMisek

pmo no - only method inside a 'trait' after '$this->'.

Example:

trait T {
 function foo() {
   $this->something(); // Won't be underlined
 }
}

class X {
  use T;
  function bar() {
    $this->anything(); // Will be (should be) underlined
  }
}

JakubMisek

pmo there might be some edge case, for example the same class is defined more times in your workspace?

i.e. class Invoice is there twice, or you have more Laravel projects in the same workspace?

JakubMisek

JakubMisek this is expected behavior:

JakubMisek

@pmo is it the only class where this issue happens?

pmo

no there is only one class Invoice and only one project in the workspace. If I remove "extends Model", I instantly get the function highlighted. But when I put it back, the error disappears. I tried with really dumb names which would make you smile so I'll not write them here, none of them triggered the error. Technically I can write $this->whateverAndItWontTriggerError() in the class. Doesn't matter which class, it doesn't work in different projects on WordPress, OctoberCMS, clean Laravel ...

JakubMisek

pmo oh, I see. Thank you for the hints - I'll check what could go wrong and get back to you.

« Previous Page