Manual namespace import

JakubMisek

Hello,

Do you mean when using such a class in your code?

editor automatically adds use when completing (auto-import)
you can resolve namespace using quick actions (ctrl+.)

Details are listed on https://docs.devsense.com/en/vscode/editor/auto-import

Or when you copy a class, and you need to prepend a namespace declaration such as:

namespace MyNamespace;

phptools

JakubMisek

Thanks! I tried ctrl + ., I did not know as it wasn't documented.

Perhaps add in the word "Quick Fix" at https://docs.devsense.com/en/vscode/editor/auto-import and it's default shortcut?

My issue was the first case:

Let's say I copied some code that uses Artisan facade
But use Illuminate\Support\Facades\Artisan; has not been added yet
If I trigger PHP Namespace Resolver, it will automatically add in use Illuminate\Support\Facades\Artisan; without any dialog/selection as there is only 1 Artisan.php in the whole project
If there are more than 1 Artisan.php, only then will a selection dialog pops up

Small thing, but makes quite a different when there are several classes to add. Thank you.

JakubMisek

I understand; so you'd like to import all the namespaces that need to be imported within a file? Otherwise, we have the import as a quickfix providing autoimport with all the possible namespaces within your workspace and syntaxes:

phptools

Yes, spot on: add all namespaces that needs to be imported. :)

JakubMisek

alright, I get it. Something like "apply all recommended fixes", or "import all namespaces"

phptools

Hi,

I realized what isn't so good about ctrl+.

Even though there is only 1 class with the name, I have to activate the quick actions, read the options, and select the one that I want.

In contrast, PHP Namespace Resolver just adds it without asking. It only asks when there are multiple classes with the same name.

Thank you.

JakubMisek

phptools implemented 😄

will be available in the next pre-release.

JakubMisek

Sadly that's how VSCode deals with Code Actions.

Although PHP Tools adds the namespace automatically already during the code completion - it's called Auto Import (https://docs.devsense.com/en/vscode/editor/auto-import). So it's even quicker.

I hope it helps,

Best,
Jakub

phptools

JakubMisek

is it possible to expose a command that I can call to resolve the namespace of the class that the cursor is on?
Today, I'm using the shortcut key ctrl + alt + i to "force" it.

The issue is that there are frequently classes of the same name, I need to select the correct one.
This plugin does it quite well https://open-vsx.org/extension/MehediDracula/php-namespace-resolver

I suspect this feature requires a language server, so I prefer to just rely on yours. Thank you.

phptools

Yea, but the automatic adding doesn't always work, especially when there are typing mistakes or editing of the names etc.

JakubMisek

phptools

Ctrl+. should do the trick (https://docs.devsense.com/en/vscode/editor/code-actions#import-name), if I understand correctly

phptools

JakubMisek

I did and tried for quite a whlie already. For instance in my project, Router class has 3 possibilities:

use Illuminate\Routing\Router;
use Google\Service\Compute\Router;
use Symfony\Component\Routing\Router;

But Quick Fix... showed No code actions available

See the difference in the 2 videos: https://imgur.com/a/Ggh0yqs

JakubMisek

phptools I see, there is no Quick Fix, because there is nothing to fix. The Router is a perfectly valid name in this context.

So you'd like to use a different Router. We don't have a "quick fix" like that, but I'll note it in our to-do to add some refactorings for this. It's a good idea!

phptools

JakubMisek

Thanks! If you could, perhaps make selection the same style like finding files/workspaces instead of a pop up :)

phptools

JakubMisek I'm "patiently" waiting for this feature. Thank you! :)

JakubMisek

phptools getting there :)

phptools

bump :)

phptools

thanks can share which version so I can test? Thank you.

JakubMisek

phptools it will be version 1.31.12887 and newer