JakubMisek I'm "patiently" waiting for this feature. Thank you! :)
Manual namespace import
phptools getting there :)
bump :)
phptools implemented 😄
will be available in the next pre-release.
thanks can share which version so I can test? Thank you.
phptools it will be version 1.31.12887
and newer
I'm on 1.33, how do I test this? Don't see any new commands with "namespace" in them.
phptools There should be quick actions, i.e.:
- Edited
Pressing ctrl + .
while my cusor was on Request
had no effect for me, nothing pops up.
Can we define our own keyboard shortcut?
(And I can't seem to attach images here... ctrl+v doesn't convert into a URL like normal and it brings me back to the previous conversation on this forum)
I think it's a different shortcut on Mac/Linux. Do you see a lightbulb if you place a cursor on Request
?
Keyboard mapping can be changed in VSCode, the command is called "Quick Fix".
Yes, I see a light bulb.
I'm on code server actually, I suppose that is Linux? I checked and found multiple definitions for ctrl + .
by default.
JakubMisek I don't think "Quick Fix" is suitable. My monitor is 1440 px in height at 100%, the list is too long to fit and there is no scrolling capability. I think switching to the ctrl + p
style is more suitable 🙏
phptools I see!
I agree. A command would make more sense in this case, and in case of anyone having so many classes.
I think https://marketplace.visualstudio.com/items?itemName=MehediDracula.php-namespace-resolver got the UI just right, do check them out.
But it is very slow compared the PHP Tools :)
phptools That would make more sense in case of more options, thank you for the tip!
We've implemented "Import class ..." command (id: "phptools.importClass"
). As suggested above, it gets a list of possible fixes as a drop-down quick-pick:
The feature is available in the latest pre-release.
I'm wondering if it would be useful to implement any other import commands?
- Edited
JakubMisek hi thanks
- Ok,
phptools.importClass
works for me! Thank you! - What do you mean by other import commands? Give me an example to think about?
- Edited
Any idea why App
and use App
appears twice?
- Edited
2 suggestions:
If my code is
\Illuminate\Support\Facades\App::blah(...)
and I runphptools.importClass
, it should still show me a list based onApp
because I might have selected a wrong namespace previously. Currently, aNo classes found
toast appears instead of the UI, I suppose it is because it cannot find alternatives to\Illuminate\Support\Facades\App
.Separate inline
Illuminate\Support\Facades\App
anduse Illuminate\Support\Facades\App
into 2 commands or make it configurable not to show the inline one. The cognitive load required to pick from a long list is quite significant and for readability, we seldom inline classnames. I usually see inline classnames only when there is a clash. Offhand, I'm thinkingctrl + alt + i
foruse
,ctrl + alt + shift + i
for inline. The command name can bephptools.inlineClass
haha