Manual namespace import

phptools

I did and tried for quite a whlie already. For instance in my project, Router class has 3 possibilities:

use Illuminate\Routing\Router;
use Google\Service\Compute\Router;
use Symfony\Component\Routing\Router;

But Quick Fix... showed No code actions available

See the difference in the 2 videos: https://imgur.com/a/Ggh0yqs

JakubMisek

phptools I see, there is no Quick Fix, because there is nothing to fix. The Router is a perfectly valid name in this context.

So you'd like to use a different Router. We don't have a "quick fix" like that, but I'll note it in our to-do to add some refactorings for this. It's a good idea!

phptools

JakubMisek

Thanks! If you could, perhaps make selection the same style like finding files/workspaces instead of a pop up :)

phptools

JakubMisek I'm "patiently" waiting for this feature. Thank you! :)

JakubMisek

phptools getting there :)

phptools

bump :)

JakubMisek

phptools implemented 😄

will be available in the next pre-release.

phptools

thanks can share which version so I can test? Thank you.

JakubMisek

phptools it will be version 1.31.12887 and newer

phptools

I'm on 1.33, how do I test this? Don't see any new commands with "namespace" in them.

JakubMisek

phptools There should be quick actions, i.e.:

phptools

JakubMisek

Pressing ctrl + . while my cusor was on Request had no effect for me, nothing pops up.
Can we define our own keyboard shortcut?

(And I can't seem to attach images here... ctrl+v doesn't convert into a URL like normal and it brings me back to the previous conversation on this forum)

JakubMisek

phptools

I think it's a different shortcut on Mac/Linux. Do you see a lightbulb if you place a cursor on Request?

Keyboard mapping can be changed in VSCode, the command is called "Quick Fix".

phptools

JakubMisek I don't think "Quick Fix" is suitable. My monitor is 1440 px in height at 100%, the list is too long to fit and there is no scrolling capability. I think switching to the ctrl + p style is more suitable 🙏

phptools

Yes, I see a light bulb.

I'm on code server actually, I suppose that is Linux? I checked and found multiple definitions for ctrl + . by default.

JakubMisek

phptools I see!

I agree. A command would make more sense in this case, and in case of anyone having so many classes.

phptools

JakubMisek

I think https://marketplace.visualstudio.com/items?itemName=MehediDracula.php-namespace-resolver got the UI just right, do check them out.

But it is very slow compared the PHP Tools :)

JakubMisek

phptools That would make more sense in case of more options, thank you for the tip!

JakubMisek

We've implemented "Import class ..." command (id: "phptools.importClass"). As suggested above, it gets a list of possible fixes as a drop-down quick-pick:

The feature is available in the latest pre-release.

I'm wondering if it would be useful to implement any other import commands?

phptools

JakubMisek hi thanks

Ok, phptools.importClass works for me! Thank you!
What do you mean by other import commands? Give me an example to think about?